Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: specify callback ip in config.json #685

Merged
merged 4 commits into from
Jun 30, 2022
Merged

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Jun 30, 2022

Signed-off-by: seeflood [email protected]

What this PR does:

  • Specify callback ip in config.json:
    image

  • Run pubsub quickstart with Java sdk

Which issue(s) this PR fixes:

Fixes #684

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #685 (aae4147) into main (97aedf9) will increase coverage by 0.02%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #685      +/-   ##
==========================================
+ Coverage   60.93%   60.95%   +0.02%     
==========================================
  Files         120      120              
  Lines        6384     6388       +4     
==========================================
+ Hits         3890     3894       +4     
  Misses       2121     2121              
  Partials      373      373              
Impacted Files Coverage Δ
pkg/runtime/config.go 60.00% <ø> (ø)
pkg/runtime/runtime.go 60.96% <83.33%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce71ce2...aae4147. Read the comment docs.

@wenxuwan wenxuwan merged commit 98c60b2 into mosn:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in-container layotto can't call back to the subscriber on the host
3 participants