-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Unit tests fail in component package #658
Conversation
Hi @leemos-xx, welcome to mosn community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
Looks good to me. The
and then |
Codecov Report
@@ Coverage Diff @@
## main #658 +/- ##
=======================================
Coverage 60.92% 60.92%
=======================================
Files 120 120
Lines 6377 6377
=======================================
Hits 3885 3885
Misses 2120 2120
Partials 372 372 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Thanks for your contribution and welcome to the community !
What this PR does:
在
components/file/s3/qiniu
目录的单测中,使用到http.Get方法向example.com
发起请求,导致部分地区无法访问该域名时,会出现单测无法通过的情况。目前通过对http的请求进行mock,来避免发起真实的请求。Which issue(s) this PR fixes:
Fixes #528