Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix legacy issues of #549 #604

Merged
merged 1 commit into from
May 25, 2022
Merged

Conversation

seeflood
Copy link
Member

Signed-off-by: seeflood [email protected]

What this PR does:
fix legacy issues of #549

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <[email protected]>
@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:yes size/M labels May 25, 2022
@seeflood seeflood requested a review from akkw May 25, 2022 03:37
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #604 (d51c819) into main (37312d8) will not change coverage.
The diff coverage is 71.42%.

@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage   60.73%   60.73%           
=======================================
  Files         120      120           
  Lines        6375     6375           
=======================================
  Hits         3872     3872           
  Misses       2133     2133           
  Partials      370      370           
Impacted Files Coverage Δ
pkg/runtime/runtime.go 60.36% <0.00%> (ø)
components/custom/registry.go 84.00% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37312d8...d51c819. Read the comment docs.

@seeflood seeflood requested a review from a team May 25, 2022 03:57
@seeflood seeflood merged commit 7a2eefd into mosn:main May 25, 2022
@seeflood seeflood deleted the fix_decouple_type branch May 25, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants