-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: reopen unit test checks and fix fatal #546
Conversation
Signed-off-by: Xunzhuo <[email protected]>
Only this test case failed |
Signed-off-by: Xunzhuo <[email protected]>
envelope is a After fixing this, I think all unit tests passed normally, we can reopen unit test check again. And we can excute |
Codecov Report
@@ Coverage Diff @@
## main #546 +/- ##
=======================================
Coverage 60.70% 60.70%
=======================================
Files 120 120
Lines 6382 6382
=======================================
Hits 3874 3874
Misses 2139 2139
Partials 369 369 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Xunzhuo I just found this issue with same error json-iterator/go#608 |
Yes, it should be an issue in jsoniter, but I think layotto is using go 1.14? |
Yes, layotto use 1.14 because mosn use 1.14 |
Signed-off-by: Xunzhuo <[email protected]>
I tried to upgrade jsoniter to 1.12, the fatal disappeared. We can keep jsoniter again, since it is with more high performance. |
see eba6443 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Xunzhuo [email protected]
What this PR does:
ci: reopen unit test checks and fix fatal
Test cases in below packages:
@echo "===========> Run unit test in sdk/go-sdk"
@echo "===========> Run unit test in components"
@echo "===========> Run unit test in pkg"
@echo "===========> Run unit test in diagnostics"
resolve: #529