Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize codes and reopen lint test ci #536

Merged
merged 13 commits into from
May 6, 2022
Merged

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented May 3, 2022

Signed-off-by: Xunzhuo [email protected]

What this PR does:

Optimize codes and reopen CI

Which issue(s) this PR fixes:

Resolve #531

@Xunzhuo Xunzhuo changed the title [WIP]: remove unused flags [WIP]: optimize codes and reopen lint test ci May 3, 2022
@Xunzhuo Xunzhuo mentioned this pull request May 3, 2022
25 tasks
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #536 (5eaab0e) into main (dbb985b) will increase coverage by 0.01%.
The diff coverage is 64.58%.

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   60.68%   60.70%   +0.01%     
==========================================
  Files         120      120              
  Lines        6384     6382       -2     
==========================================
  Hits         3874     3874              
+ Misses       2140     2139       -1     
+ Partials      370      369       -1     
Impacted Files Coverage Δ
components/configstores/apollo/repository.go 11.42% <0.00%> (ø)
pkg/common/log.go 0.00% <0.00%> (ø)
pkg/filter/stream/actuator/http/dispatch_filter.go 0.00% <0.00%> (ø)
pkg/grpc/default_api/api_sequencer.go 64.28% <0.00%> (ø)
pkg/integrate/actuator/runtime_indicator.go 100.00% <ø> (ø)
pkg/runtime/sequencer/cache.go 65.97% <0.00%> (ø)
pkg/wasm/dispatch.go 0.00% <0.00%> (ø)
pkg/grpc/default_api/api_pubsub.go 41.93% <28.57%> (ø)
pkg/grpc/dapr/dapr_api.go 58.53% <50.00%> (ø)
pkg/grpc/default_api/api_configuration.go 78.40% <80.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac12ca3...5eaab0e. Read the comment docs.

@mosn-community-bot mosn-community-bot bot added size/L and removed size/M labels May 3, 2022
@Xunzhuo Xunzhuo changed the title [WIP]: optimize codes and reopen lint test ci feat: optimize codes and reopen lint test ci May 3, 2022
@Xunzhuo
Copy link
Member Author

Xunzhuo commented May 3, 2022

merge after #527

@Xunzhuo Xunzhuo marked this pull request as ready for review May 3, 2022 11:25
JervyShi
JervyShi previously approved these changes May 4, 2022
Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/grpc/default_api/api.go Outdated Show resolved Hide resolved
@Xunzhuo Xunzhuo requested a review from seeflood May 5, 2022 07:32
pkg/runtime/bindings/registry.go Outdated Show resolved Hide resolved
pkg/runtime/bindings/registry.go Outdated Show resolved Hide resolved
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Xunzhuo Xunzhuo requested a review from seeflood May 6, 2022 09:38
@seeflood seeflood merged commit 40b8e8e into mosn:main May 6, 2022
@Xunzhuo Xunzhuo deleted the reopen-lint branch May 6, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reopen Lint Tests after fixing
4 participants