Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add secret demo and doc #525

Merged
merged 23 commits into from
May 15, 2022
Merged

docs: add secret demo and doc #525

merged 23 commits into from
May 15, 2022

Conversation

ZLBer
Copy link
Member

@ZLBer ZLBer commented May 2, 2022

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Change the `secretStores` field in config.json to `secret_store`

@ZLBer ZLBer changed the title doc: add secret demo and doc docs: add secret demo and doc May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #525 (2efacaf) into main (15daa68) will not change coverage.
The diff coverage is n/a.

❗ Current head 2efacaf differs from pull request most recent head 0d7a599. Consider uploading reports for the commit 0d7a599 to get more accurate results

@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   60.70%   60.70%           
=======================================
  Files         120      120           
  Lines        6382     6382           
=======================================
  Hits         3874     3874           
  Misses       2139     2139           
  Partials      369      369           
Impacted Files Coverage Δ
pkg/runtime/config.go 60.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15daa68...0d7a599. Read the comment docs.

@seeflood seeflood requested a review from MentosL May 5, 2022 02:27
docs/_sidebar.md Show resolved Hide resolved
docs/zh/_sidebar.md Show resolved Hide resolved
configs/config_secret_local_file.json Outdated Show resolved Hide resolved
configs/config_secret_file.json Show resolved Hide resolved
configs/config_secret_file.json Outdated Show resolved Hide resolved
demo/secret/file/client.go Outdated Show resolved Hide resolved
docs/zh/start/secret/start.md Show resolved Hide resolved
docs/zh/_sidebar.md Show resolved Hide resolved
docs/_sidebar.md Show resolved Hide resolved
demo/secret/common/client.go Show resolved Hide resolved
demo/secret/common/client.go Show resolved Hide resolved
demo/secret/env/client.go Outdated Show resolved Hide resolved
docs/en/start/secret/start.md Outdated Show resolved Hide resolved
docs/en/start/secret/start.md Outdated Show resolved Hide resolved
docs/en/start/secret/start.md Outdated Show resolved Hide resolved
demo/secret/common/client.go Show resolved Hide resolved
docs/en/start/secret/start.md Show resolved Hide resolved
docs/zh/start/secret/start.md Outdated Show resolved Hide resolved
docs/zh/start/secret/start.md Outdated Show resolved Hide resolved
docs/zh/start/secret/start.md Show resolved Hide resolved
docs/zh/start/secret/start.md Outdated Show resolved Hide resolved
demo/secret/env/client.go Outdated Show resolved Hide resolved
@ZLBer
Copy link
Member Author

ZLBer commented May 14, 2022

@seeflood delete other demos

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seeflood
Copy link
Member

The quickstart failed:
image
It's caused by the k8s config in the json file and we can delete it
image

@ZLBer
Copy link
Member Author

ZLBer commented May 14, 2022

@seeflood done

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood requested review from a team May 15, 2022 10:57
@Xunzhuo Xunzhuo merged commit c1fe556 into mosn:main May 15, 2022
@seeflood seeflood added this to the v0.5 milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants