-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: layotto rpc code analysis #494
Conversation
Codecov Report
@@ Coverage Diff @@
## main #494 +/- ##
=======================================
Coverage 60.60% 60.60%
=======================================
Files 120 120
Lines 6382 6382
=======================================
Hits 3868 3868
Misses 2144 2144
Partials 370 370 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this doc to the sidebar.
See https://mosn.io/layotto/#/zh/development/contributing-doc?id=%e6%96%b0%e5%a2%9e%e6%96%87%e6%a1%a3%e9%9c%80%e8%a6%81%e5%81%9a%e5%93%aa%e4%ba%9b%e4%ba%8b
The sidebar has been updated, and by the way, all the current source code analysis documents have been moved to /zh/blog/code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks for your detailed article !
What this PR does:
layotto rpc code analysis
Which issue(s) this PR fixes:
Fixes #424
Special notes for your reviewer:
Because it took some time to repair dubbo-go-sample before, and now the deadline is up, so I submit a version first. I hope that the tutor and maintainers can help to see if there is anything that needs to be supplemented and improved. In addition, I will add a summary and further improvement over the weekend.
Further more, I would like to make a suggestion that the source code analysis document should be similar to other open source projects. All source code analysis can create a separate code directory under the blog directory, and then create another subdirectory under the code directory to submit markdown files and pictures and other related files.
Does this PR introduce a user-facing change?:
NONE