Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: layotto rpc code analysis #494

Merged
merged 11 commits into from
Apr 29, 2022
Merged

Conversation

rayowang
Copy link
Member

What this PR does:
layotto rpc code analysis

Which issue(s) this PR fixes:
Fixes #424

Special notes for your reviewer:
Because it took some time to repair dubbo-go-sample before, and now the deadline is up, so I submit a version first. I hope that the tutor and maintainers can help to see if there is anything that needs to be supplemented and improved. In addition, I will add a summary and further improvement over the weekend.

Further more, I would like to make a suggestion that the source code analysis document should be similar to other open source projects. All source code analysis can create a separate code directory under the blog directory, and then create another subdirectory under the code directory to submit markdown files and pictures and other related files.

Does this PR introduce a user-facing change?:
NONE

@rayowang rayowang changed the title layotto rpc code analysis doc: layotto rpc code analysis Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #494 (c9c45c9) into main (2e383f1) will not change coverage.
The diff coverage is n/a.

❗ Current head c9c45c9 differs from pull request most recent head 01d19d5. Consider uploading reports for the commit 01d19d5 to get more accurate results

@@           Coverage Diff           @@
##             main     #494   +/-   ##
=======================================
  Coverage   60.60%   60.60%           
=======================================
  Files         120      120           
  Lines        6382     6382           
=======================================
  Hits         3868     3868           
  Misses       2144     2144           
  Partials      370      370           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e383f1...01d19d5. Read the comment docs.

@seeflood seeflood requested a review from zhenjunMa April 22, 2022 09:02
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rayowang
Copy link
Member Author

Please add this doc to the sidebar. See https://mosn.io/layotto/#/zh/development/contributing-doc?id=%e6%96%b0%e5%a2%9e%e6%96%87%e6%a1%a3%e9%9c%80%e8%a6%81%e5%81%9a%e5%93%aa%e4%ba%9b%e4%ba%8b image

The sidebar has been updated, and by the way, all the current source code analysis documents have been moved to /zh/blog/code.

zhenjunMa
zhenjunMa previously approved these changes Apr 27, 2022
Copy link
Contributor

@zhenjunMa zhenjunMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/zh/blog/code/layotto-rpc/index.md Outdated Show resolved Hide resolved
@seeflood seeflood closed this Apr 29, 2022
@seeflood seeflood reopened this Apr 29, 2022
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for your detailed article !

@seeflood seeflood merged commit 374ab9a into mosn:main Apr 29, 2022
@seeflood seeflood mentioned this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

源码解析: 处理 rpc 请求
3 participants