Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trace not running #403

Merged
merged 1 commit into from
Mar 3, 2022
Merged

fix: trace not running #403

merged 1 commit into from
Mar 3, 2022

Conversation

stulzq
Copy link
Member

@stulzq stulzq commented Mar 3, 2022

What this PR does:
fix trace not running on cmd/layotto, trace exporter not register
Which issue(s) this PR fixes:

None
Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:yes size/XS labels Mar 3, 2022
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #403 (155bacc) into main (a4cd3ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   57.43%   57.43%           
=======================================
  Files         115      115           
  Lines        6143     6143           
=======================================
  Hits         3528     3528           
  Misses       2255     2255           
  Partials      360      360           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4cd3ed...155bacc. Read the comment docs.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenxuwan wenxuwan merged commit 028c0b5 into mosn:main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants