-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sequencer of mongo #376
Conversation
Codecov Report
@@ Coverage Diff @@
## main #376 +/- ##
==========================================
+ Coverage 54.26% 54.72% +0.45%
==========================================
Files 108 108
Lines 5921 5972 +51
==========================================
+ Hits 3213 3268 +55
+ Misses 2380 2365 -15
- Partials 328 339 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
The binary file demo/configuration/apollo/apolloClientDemo
shouldn't be added. You can add it into .gitignore
Could u help add documents for mongodb lock and mongodb sequencer ? You can take consul lock chinese doc and consul lock english doc as examples. @ZLBer @whalesongAndLittleFish @stulzq Could you help review this PR in detail ? Thanks! |
@seeflood I need to take an exam in the next few days, and I'll be adding documents for mongodb lock and mongodb sequencer over the weekend. |
@LXPWing Wish you success in your exam ! 青春 is so beautiful 😢 |
Hi @seeflood I don't understand why codecov/project is wrong and I should do |
@seeflood some bugs of codecov? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @seeflood Do I need to modify components/rpc/invoker/mosn/channel/xchannel.go ? |
@LXPWing About the codecov warning:
|
@LXPWing I have reviewed this PR, please fix the codecov problem as above, then we will merged, thanks. |
…o feature/add-sequencer-mongo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for your contribution ! |
What this PR does:
add sequencer of mongo #149