-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move proto related code to a different package #375
Conversation
Codecov Report
@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 57.42% 57.52% +0.09%
==========================================
Files 107 108 +1
Lines 5762 5832 +70
==========================================
+ Hits 3309 3355 +46
- Misses 2114 2134 +20
- Partials 339 343 +4
Continue to review full report at Codecov.
|
States: convertStatesToDaprPB(in.States), | ||
} | ||
// delegate to dapr api implementation | ||
return a.daprAPI.SaveState(ctx, daprReq) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the Dapr SaveState API as an example @zach030
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
What this PR does:
Move proto related code to a different package.
It will make the code clean and easy to import
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: