Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move proto related code to a different package #375

Closed
wants to merge 13 commits into from

Conversation

seeflood
Copy link
Member

What this PR does:
Move proto related code to a different package.
It will make the code clean and easy to import

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #375 (d3af1f4) into main (be22e2f) will increase coverage by 0.09%.
The diff coverage is 43.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   57.42%   57.52%   +0.09%     
==========================================
  Files         107      108       +1     
  Lines        5762     5832      +70     
==========================================
+ Hits         3309     3355      +46     
- Misses       2114     2134      +20     
- Partials      339      343       +4     
Impacted Files Coverage Δ
pkg/grpc/dapr/dapr_api_state.go 0.00% <0.00%> (ø)
pkg/grpc/default_api/api_callback.go 20.38% <0.00%> (ø)
pkg/grpc/default_api/lock.go 100.00% <ø> (ø)
pkg/grpc/default_api/sequencer.go 56.25% <ø> (ø)
pkg/runtime/state/compatibility.go 100.00% <ø> (+25.45%) ⬆️
pkg/grpc/default_api/api_state.go 82.35% <82.22%> (ø)
pkg/grpc/default_api/api.go 75.95% <94.73%> (+0.14%) ⬆️
pkg/grpc/default_api/subscriptions.go 62.50% <100.00%> (ø)
components/lock/zookeeper/zookeeper_lock.go 64.28% <0.00%> (+8.92%) ⬆️
pkg/runtime/options.go 34.09% <0.00%> (+20.45%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be22e2f...d3af1f4. Read the comment docs.

States: convertStatesToDaprPB(in.States),
}
// delegate to dapr api implementation
return a.daprAPI.SaveState(ctx, daprReq)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the Dapr SaveState API as an example @zach030

@seeflood seeflood closed this Dec 27, 2021
@seeflood seeflood reopened this Dec 27, 2021
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 7, 2022
@seeflood seeflood closed this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant