Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove java-sdk and add link to repo #357

Merged
merged 1 commit into from
Dec 6, 2021
Merged

refactor: remove java-sdk and add link to repo #357

merged 1 commit into from
Dec 6, 2021

Conversation

kevinten10
Copy link
Member

What this PR does:

  • Remove java code in mosn/layotto repo
  • Add a link like js-sdk's

Which issue(s) this PR fixes:

Fixes #layotto/java-sdk#6

Special notes for your reviewer:

no

Does this PR introduce a user-facing change?:

no


@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #357 (a3592bb) into main (978b472) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   57.90%   57.90%           
=======================================
  Files          48       48           
  Lines        2226     2226           
=======================================
  Hits         1289     1289           
  Misses        791      791           
  Partials      146      146           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 978b472...a3592bb. Read the comment docs.

@seeflood
Copy link
Member

seeflood commented Dec 6, 2021

Thanks for your contribution!

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l g t m

@wenxuwan wenxuwan merged commit a1dfd71 into mosn:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants