-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mongo distributed lock #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
demo/configuration/apollo/apolloClientDemo
There is no need to submit this binary file :)
Thanks for your contribution! |
关于如何在ut中mock掉mongoDB:
可以参考 @ZLBer 之前写的zookeeper lock 他当时也面临同样的问题(如何在ut里mock zk),解决方案是把zk 的connection封装成一个interface: layotto/components/pkg/utils/zookeeper.go Line 53 in e0e5eba
|
@ZLBer @whalesongAndLittleFish @stulzq Hi guys, could u help review this PR? |
Codecov Report
@@ Coverage Diff @@
## main #348 +/- ##
=======================================
Coverage 57.62% 57.62%
=======================================
Files 48 48
Lines 2289 2289
=======================================
Hits 1319 1319
Misses 837 837
Partials 133 133 Continue to review full report at Codecov.
|
@LXPWing no big problem, next ,you need to add docs in |
…ck' into feature/add-mongo-distributed-lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice~,LGTM
# Conflicts: # components/go.sum # go.sum
Sorry for not replying ! I will submit a PR to fix the test cases and then go back to test and merge this PR. |
Thanks again for your contribution! |
@LXPWing Thanks for your contribution! Maybe you can try another community task~ |
What this PR does:
add mongo distributed lock
Which issue(s) this PR fixes:
#104