Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(java-sdk): java sdk support File API #325

Merged
merged 3 commits into from
Dec 2, 2021
Merged

feat(java-sdk): java sdk support File API #325

merged 3 commits into from
Dec 2, 2021

Conversation

ccx1024cc
Copy link
Contributor

Including PutFile, GetFile, DelFile, ListFile

@codecov
Copy link

codecov bot commented Nov 18, 2021 •
edited
Loading

Codecov Report

Merging #325 (04819ae) into java_sdk_1.1.0 (408876e) will not change coverage.
The diff coverage is n/a.

❗ Current head 04819ae differs from pull request most recent head f1eb7f3. Consider uploading reports for the commit f1eb7f3 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           java_sdk_1.1.0     #325   +/-   ##
===============================================
  Coverage           56.90%   56.90%           
===============================================
  Files                  48       48           
  Lines                2100     2100           
===============================================
  Hits                 1195     1195           
  Misses                774      774           
  Partials              131      131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408876e...f1eb7f3. Read the comment docs.

ujjboy
ujjboy requested changes Nov 19, 2021
View reviewed changes
@wenxuwan
Copy link
Member

1.实现一下getmeta接口
2.对于java的异常不要显示的return，直接throw出来。

@ccx1024cc
Copy link
Contributor Author

1.实现一下getmeta接口 2.对于java的异常不要显示的return，直接throw出来。

Done @wenxuwan

@ujjboy
Copy link
Member

ujjboy commented Nov 23, 2021

@seeflood 这个 JAVA 的 CI 是不是没有配置啊，我怎么看是在跑 go 的

@wenxuwan
Copy link
Member

@seeflood 这个 JAVA 的 CI 是不是没有配置啊，我怎么看是在跑 go 的

CI仓库里面只有golang的

ujjboy
ujjboy requested changes Nov 24, 2021
View reviewed changes
@ujjboy ujjboy self-requested a review December 2, 2021 06:40
ujjboy
ujjboy approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujjboy ujjboy merged commit 8e6c4e4 into mosn:java_sdk_1.1.0 Dec 2, 2021
seeflood added a commit to seeflood/layotto that referenced this pull request Dec 5, 2021
@seeflood @kevinten10
@Nancy945 @ccx1024cc @ZLBer
Test (#2)
0f239b3 
* add client interface copied from cloud-runtime-jvm

* remove secret interface

* add non-reactor interface

* refactor: format java-sdk code (mosn#210)

* feat: create reactor-java-sdk refer to dapr-java-sdk (mosn#226)

* doc: Create a start-from-zero guide to become a new contributor (mosn#337)

* Update start-apollo.md (mosn#344)

* feat(java-sdk): java sdk support File API (mosn#325)

Co-authored-by: 泰友 <[email protected]>

* feat: Double buffer for sequencer catch (mosn#231)

* split into different modules

* split into different modules

* feat(java-sdk):spilt into different modules

Co-authored-by: Kevin_T <[email protected]>
Co-authored-by: Nancy <[email protected]>
Co-authored-by: ccx1024cc <[email protected]>
Co-authored-by: 泰友 <[email protected]>
Co-authored-by: ZLBer <[email protected]>
seeflood pushed a commit that referenced this pull request Dec 6, 2021
@ccx1024cc
feat(java-sdk): java sdk support File API (#325) (#356)
17ec7a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seeflood seeflood seeflood requested changes

@ujjboy ujjboy ujjboy approved these changes

@wenxuwan wenxuwan wenxuwan approved these changes

Assignees

@seeflood seeflood

Labels
cla:yes First-time contributor size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccx1024cc @wenxuwan @ujjboy @seeflood