Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): Add links to dotnet and js sdk #317

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

seeflood
Copy link
Member

What this PR does:
delete gitmodules;
add README and links to dotnet and js sdk instead.

Which issue(s) this PR fixes:

I just found that git submodules can only be linked to a fixed commit id. It cannot link to the latest commit of a branch.
So I decide to use a README instead

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #317 (8ee3b2c) into main (382f08e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   56.90%   56.90%           
=======================================
  Files          48       48           
  Lines        2100     2100           
=======================================
  Hits         1195     1195           
  Misses        774      774           
  Partials      131      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 382f08e...8ee3b2c. Read the comment docs.

@seeflood seeflood merged commit c608d04 into mosn:main Nov 16, 2021
@seeflood seeflood deleted the no_gitmodules branch November 16, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants