Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http channel deadconn detection #291

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

MoonShining
Copy link
Contributor

@MoonShining MoonShining commented Oct 28, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #285

  1. https://datatracker.ietf.org/doc/html/rfc7540#section-8.1.2.6 clarified content-length header is optional, so just drop it
  2. add http connection close check

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #291 (3c672f4) into main (32c4ed5) will decrease coverage by 0.07%.
The diff coverage is 33.33%.

❗ Current head 3c672f4 differs from pull request most recent head 0c999c6. Consider uploading reports for the commit 0c999c6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
- Coverage   56.73%   56.65%   -0.08%     
==========================================
  Files          48       48              
  Lines        2057     2058       +1     
==========================================
- Hits         1167     1166       -1     
- Misses        768      769       +1     
- Partials      122      123       +1     
Impacted Files Coverage Δ
pkg/grpc/api.go 72.39% <33.33%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c4ed5...0c999c6. Read the comment docs.

@MoonShining MoonShining force-pushed the fix/http-deadconn-detection branch 2 times, most recently from 05c41b7 to 8e194ab Compare November 1, 2021 12:22
pkg/grpc/api.go Show resolved Hide resolved
components/rpc/invoker/mosn/channel/httpchannel.go Outdated Show resolved Hide resolved
@MoonShining MoonShining force-pushed the fix/http-deadconn-detection branch 2 times, most recently from dbbaed2 to eb72bd2 Compare November 2, 2021 08:36
wenxuwan
wenxuwan previously approved these changes Nov 2, 2021
Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenxuwan wenxuwan merged commit 7a133d2 into mosn:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] RPC api forwards http headers incorrectly
2 participants