Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): add commit lint workflow #244

Merged
merged 3 commits into from
Oct 19, 2021
Merged

chore(workflow): add commit lint workflow #244

merged 3 commits into from
Oct 19, 2021

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Oct 2, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #243

Special notes for your reviewer: @seeflood

Does this PR introduce a user-facing change?:

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2021

Codecov Report

Merging #244 (2b0cd99) into main (debc417) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   56.73%   56.73%           
=======================================
  Files          48       48           
  Lines        2057     2057           
=======================================
  Hits         1167     1167           
  Misses        768      768           
  Partials      122      122           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update debc417...2b0cd99. Read the comment docs.

@seeflood
Copy link
Member

seeflood commented Oct 8, 2021

Thanks for your contribution!
This is indeed a problem that keeps bothering me and we really need your help.

Our current workflow has the following problems:

  1. Some pull request lack descriptions,but they are easily merged after private communication, making it difficult for others to understand what happened.
  2. Since we want to make the requirements of alipay directly developed in the open source layotto, we hope to iterate on the open source layotto quickly, but how to ensure the stability while iterating quickly? When we develop projects in the company, we need QA teams to conduct rigorous testing, but the open source version does not have a person responsible for testing. Pull requests in github are easily merged after code review and unit testing, and they will be deployed to the production environment after the merge,which makes me feel not confident.

It seems that the tool you suggest is a good way to solve problem 1.
Let me check if we can add more automatic validation and force developers to add more description in their PR using your tool.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@seeflood seeflood merged commit 253cd21 into mosn:main Oct 19, 2021
seeflood added a commit that referenced this pull request Oct 19, 2021
seeflood added a commit that referenced this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add commit message lint to workflow
3 participants