-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: load multi wasm plugins #182
Conversation
Codecov Report
@@ Coverage Diff @@
## main #182 +/- ##
==========================================
- Coverage 58.24% 56.56% -1.68%
==========================================
Files 50 51 +1
Lines 2148 2215 +67
==========================================
+ Hits 1251 1253 +2
- Misses 775 841 +66
+ Partials 122 121 -1
Continue to review full report at Codecov.
|
整体思路完全正确👍,部分细节可以再讨论下 |
一开始想改成加权轮训,不过发现把注册路由放到OnPluginStart里其实会每一个instance都注册一次,实际上已经等于是加权了,所以又改回随机了 也就是说getID这个行为,每一个wasm都会运行instanceNum次,我觉得还是放在原来的位置好 |
是的,放在 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
非常感谢贡献如此重要的feature🍺
What this PR does:
Let layotto support loading multi wasm plugins
Which issue(s) this PR fixes:
Fixes #176
Special notes for your reviewer:
Idea validation, not completed, encountered major obstacles
Does this PR introduce a user-facing change?: