Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add ut for pkg/wasm #1013

Merged
merged 17 commits into from
Oct 31, 2023
Merged

test: add ut for pkg/wasm #1013

merged 17 commits into from
Oct 31, 2023

Conversation

ChloroplastYu
Copy link
Contributor

@ChloroplastYu ChloroplastYu commented Oct 27, 2023

What this PR does:
add ut for pkg/wasm
image

Related issue:
#105

Does this PR introduce a user-facing change?:

NONE

@github-actions
Copy link

Hi @ChloroplastYu. Thanks for your PR! 🎉
If the PR is ready, use the /cc command to assign reviewer to review.

Details

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

@ChloroplastYu ChloroplastYu changed the title Add ut for pkg/wasm test: add ut for pkg/wasm Oct 27, 2023
@ChloroplastYu
Copy link
Contributor Author

@zhenjunMa please review, thank you!

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Attention: 115 lines in your changes are missing coverage. Please review.

Files Coverage Δ
components/custom/registry.go 84.00% <100.00%> (ø)
components/hello/helloworld/helloworld.go 100.00% <100.00%> (ø)
components/pluggable/config.go 100.00% <100.00%> (ø)
components/pluggable/register.go 100.00% <100.00%> (ø)
pkg/runtime/secretstores/factory.go 100.00% <100.00%> (ø)
pkg/runtime/secretstores/registry.go 100.00% <100.00%> (ø)
pkg/wasm/abi.go 8.69% <ø> (ø)
pkg/wasm/dispatch.go 100.00% <ø> (+76.19%) ⬆️
pkg/wasm/factory.go 73.24% <100.00%> (+48.88%) ⬆️
pkg/wasm/filter.go 61.11% <ø> (+61.11%) ⬆️
... and 8 more

📢 Thoughts on this report? Let us know!.

@ChloroplastYu
Copy link
Contributor Author

/cc @zhenjunMa

@Xunzhuo
Copy link
Member

Xunzhuo commented Oct 31, 2023

/lgtm
/approve

Great job. Thanks for working on it.

@Xunzhuo Xunzhuo merged commit fe66f40 into mosn:main Oct 31, 2023
29 checks passed
@ChloroplastYu ChloroplastYu deleted the test/wasm-ut branch November 1, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants