Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor canSkipMethods logic #803

Merged
merged 1 commit into from
Nov 22, 2024
Merged

chore: refactor canSkipMethods logic #803

merged 1 commit into from
Nov 22, 2024

Conversation

spacewander
Copy link
Member

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (5affbd8) to head (09daa46).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/pkg/filtermanager/filtermanager.go 96.15% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
+ Coverage   87.07%   87.09%   +0.01%     
==========================================
  Files         145      145              
  Lines        8715     8704      -11     
==========================================
- Hits         7589     7581       -8     
+ Misses        877      875       -2     
+ Partials      249      248       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@spacewander spacewander marked this pull request as ready for review November 20, 2024 03:45
@spacewander spacewander merged commit 0d60076 into main Nov 22, 2024
19 checks passed
@spacewander spacewander deleted the 1120 branch November 22, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant