-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable holmes as pyroscope client and reports pprof event to pyroscope server #109
Conversation
demo on example/pyroscope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some doc for this new reporter, otherwise, LGTM.
|
||
#### Enable holmes as pyroscope client | ||
|
||
Holmes supports to upload your profile to [pyroscope](https://github.com/pyroscope-io/pyroscope) server. More details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need some simple doc, for how to enable this feature.
Assuming that people already have a pyroscope service.
Holmes used a different approach from continuous profiling, I don't know whether it's proper to integrate the event triggered profile to conprof based platform pyroscope, have you already used it on your production env? @Jun10ng |
Pyroscope can provides visual web view for holmes and user can both enable holmes and pyroscope-client. not yet. we only use it on non-live env such as stress test. |
#104