Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable holmes as pyroscope client and reports pprof event to pyroscope server #109

Merged
merged 8 commits into from
Jul 23, 2022

Conversation

Jun10ng
Copy link
Contributor

@Jun10ng Jun10ng commented Jul 8, 2022

@Jun10ng
Copy link
Contributor Author

Jun10ng commented Jul 8, 2022

demo on example/pyroscope

Copy link
Member

@doujiang24 doujiang24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some doc for this new reporter, otherwise, LGTM.

@Jun10ng Jun10ng requested a review from doujiang24 July 11, 2022 13:09
@Jun10ng
Copy link
Contributor Author

Jun10ng commented Jul 14, 2022

@doujiang24


#### Enable holmes as pyroscope client

Holmes supports to upload your profile to [pyroscope](https://github.com/pyroscope-io/pyroscope) server. More details
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need some simple doc, for how to enable this feature.
Assuming that people already have a pyroscope service.

@doujiang24 doujiang24 requested a review from cch123 July 18, 2022 02:23
@cch123 cch123 changed the title Enable holmes as pyroscope client and reports pprof evevnt to pyroscope server Enable holmes as pyroscope client and reports pprof event to pyroscope server Jul 18, 2022
@cch123
Copy link
Collaborator

cch123 commented Jul 18, 2022

Holmes used a different approach from continuous profiling, I don't know whether it's proper to integrate the event triggered profile to conprof based platform pyroscope, have you already used it on your production env? @Jun10ng

@Jun10ng
Copy link
Contributor Author

Jun10ng commented Jul 18, 2022

Holmes used a different approach from continuous profiling, I don't know whether it's proper to integrate the event triggered profile to conprof based platform pyroscope, have you already used it on your production env? @Jun10ng

Pyroscope can provides visual web view for holmes and user can both enable holmes and pyroscope-client.

not yet. we only use it on non-live env such as stress test.

@doujiang24 doujiang24 merged commit 8bfa326 into mosn:master Jul 23, 2022
@Jun10ng Jun10ng deleted the holmes-pyroscope-client branch August 3, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants