Skip to content

Gpg update test - #2130

Merged
anushasunkada merged 5 commits into
mosip:developfrom
Mahesh-Binayak:gpg-update
Jul 7, 2026
Merged

Gpg update test#2130
anushasunkada merged 5 commits into
mosip:developfrom
Mahesh-Binayak:gpg-update

Conversation

@Mahesh-Binayak

@Mahesh-Binayak Mahesh-Binayak commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated build and publishing automation to use the latest shared workflows.
    • Added support for passing a GPG private key through Maven build and publishing steps, improving signed artifact handling.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Mahesh-Binayak, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0c32abed-7bcf-4071-978b-17be0f55ceb0

📥 Commits

Reviewing files that changed from the base of the PR and between 3bf4696 and 710411c.

📒 Files selected for processing (2)
  • .github/workflows/manual-docker-build.yml
  • .github/workflows/push-trigger.yml

Walkthrough

Two GitHub Actions workflow files update reusable workflow references from master/master-java21 branches to gpgupdate-masterj21, and add GPG_PRIVATE_KEY secret passthrough to Maven build, Nexus publish, and Sonar analysis job definitions.

Changes

CI Workflow GPG Key Passthrough

Layer / File(s) Summary
Manual docker build workflow update
.github/workflows/manual-docker-build.yml
build_maven_esignet_with_plugins job's maven-build.yml reference switches to @gpgupdate-masterj21 and its secrets block now includes GPG_PRIVATE_KEY.
Push-trigger Maven build jobs updated
.github/workflows/push-trigger.yml
build_maven_esignet, build_maven_esignet_with_plugins, and build_maven_apitest_esignet jobs switch maven-build.yml refs to @gpgupdate-masterj21 and pass GPG_PRIVATE_KEY in secrets.
Push-trigger publish and sonar jobs updated
.github/workflows/push-trigger.yml
publish_to_nexus, sonar_analysis, and publish_to_nexus_apitest_esignet jobs switch their reusable workflow refs to @gpgupdate-masterj21 and pass GPG_PRIVATE_KEY in secrets.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

Hop, hop, through YAML fields I go,
Swapping branches row by row,
A tiny key now tags along,
GPG_PRIVATE_KEY, signed and strong,
🐇 Build, publish, sonar too —
All aligned on gpgupdate-masterj21's crew!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the main change, which updates GPG-related workflow references and secrets.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/manual-docker-build.yml:
- Line 15: The reusable workflow reference in the manual Docker build workflow
is pinned to a mutable branch ref, which should be replaced with a stable tag or
commit SHA. Update the workflow invocation that uses
mosip/kattu/.github/workflows/maven-build.yml to point at an immutable ref, and
if this branch-based ref is only for temporary testing, document that it is
intentional and ensure there is a follow-up to switch to a stable ref before
merging.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8a91f841-3abe-4479-b67c-8097c741ba79

📥 Commits

Reviewing files that changed from the base of the PR and between db78d05 and 3bf4696.

📒 Files selected for processing (2)
  • .github/workflows/manual-docker-build.yml
  • .github/workflows/push-trigger.yml

Comment thread .github/workflows/manual-docker-build.yml
Mahesh-Binayak and others added 5 commits July 7, 2026 17:53
Repoints maven-build / maven-publish-to-nexus / maven-sonar-analysis(-new)
reusable-workflow references to mosip/kattu@develop so the GPG-key-import
migration (mosip/kattu#353) is exercised by this repo's CI once it merges.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in>
kattu#353 imports the signing key from the GPG_PRIVATE_KEY secret (now
required: true in maven-build / maven-publish-to-nexus workflow_call), so
the caller must forward it. Added GPG_PRIVATE_KEY to the maven-build and
maven-publish-to-nexus caller jobs only (sonar workflows don't declare it).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in>
kattu@develop maven-build.yml does not declare MAVEN_NON_EXEC_ARTIFACTS
(it was a master-java21-only input), which fails workflow validation.
Remove it from the caller so the reusable workflow reference is valid.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in>
gpgupdate-masterj21 = master-java21 + the GPG-secret-import / key-age /
simplify4u-pgpverify changes, keeping master-java21's interface intact.
Repoints maven-build / maven-publish-to-nexus / maven-sonar-analysis to it,
restores MAVEN_NON_EXEC_ARTIFACTS, and forwards GPG_PRIVATE_KEY to the
build/publish jobs. Other workflows (docker-build, npm-*, sonar-new@develop)
and commented refs are left unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in>
The gpgupdate-masterj21 branch (master-java21 + GPG-secret/pgpverify
changes) now lives on mosip/kattu, so reference it there instead of the
fork. Interface unchanged; GPG_PRIVATE_KEY still forwarded.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Mahesh.Binayak <mahesh.binayak@technoforte.co.in>
@anushasunkada
anushasunkada merged commit 565553e into mosip:develop Jul 7, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants