chore: use toplevel out/ for importing Morpho bytecode#388
Merged
Conversation
QGarchery
reviewed
Jan 8, 2024
Rubilmax
reviewed
Jan 8, 2024
Co-authored-by: Quentin Garchery <QGarchery@users.noreply.github.com> Signed-off-by: Adrien Husson <adhusson@gmail.com>
MerlinEgalite
approved these changes
Jan 9, 2024
Co-authored-by: Quentin Garchery <QGarchery@users.noreply.github.com> Signed-off-by: Adrien Husson <adhusson@gmail.com>
Collaborator
Author
|
Updated hardhat config by adding a compiler. Hardhat will select the highest compiler version compatible with the pragma in each instance. FYI you could also be more specific and do the following: |
QGarchery
requested changes
Jan 10, 2024
Rubilmax
reviewed
Jan 10, 2024
QGarchery
approved these changes
Jan 12, 2024
Rubilmax
approved these changes
Jan 12, 2024
Jean-Grimal
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following issue : after a fresh checkout,
forge testfails. The relevant trace portion is:The current fix is to
cd lib/morpho-blue; forge build; cd ../.., and to do it again after any change to the localMorpho.sol.This PR uses foundry's multiple compiler version support to compile Morpho separately. No more need to build inside the
lib/morpho-bluedir to get the Morpho bytecode.Important: Morpho's solidity version will be used, but metamorpho's optimization settings will be used.