Skip to content

Correct name generation of GQLType instances for types parametrised by promoted constructors #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Correct name generation of GQLType instances for types parametrised by promoted constructors #879

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c62a238
remove constructor ticks
alleksandrgall Aug 8, 2025
9240ce4
settings json
alleksandrgall Aug 8, 2025
7fe25db
newline
alleksandrgall Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion morpheus-graphql-server/src/Data/Morpheus/Server/Types/TypeName.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ instance Hashable TypeFingerprint where
hashWithSalt s (CustomFingerprint x) = hashWithSalt s (3 :: Int, x)

typeableTypename :: (Typeable a) => f a -> TypeName
typeableTypename = packName . intercalate "" . fmap (pack . tyConName . replacePairCon) . getTypeConstructors
typeableTypename = packName . intercalate "" . fmap (pack . dropLeadingTick . tyConName . replacePairCon) . getTypeConstructors

toCategory :: CatType c a -> TypeCategory
toCategory InputType = IN
Expand All @@ -92,6 +92,10 @@ typeableFingerprint p =
getTypeConstructors :: (Typeable a) => f a -> [TyCon]
getTypeConstructors = ignoreResolver . splitTyConApp . typeRep

-- Filter out ticks from promoted constructors
dropLeadingTick :: String -> String
dropLeadingTick = Prelude.dropWhile (== '\'')
Copy link
Member

@nalchevanidze nalchevanidze Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alleksandrgall whycould you please describe problem? and add tests?


rep :: forall k (a :: k) f. (Typeable a) => f a -> TyCon
rep = typeRepTyCon . typeRep

Expand Down