Skip to content

Added Turkcealtyazi.org provider for Turkish subtitles #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

casab
Copy link

@casab casab commented Jan 25, 2025

After seeing this, I have decided to write it myself;
https://bazarr.featureupvote.com/suggestions/56901/provider-request-add-httpsturkcealtyaziorg-as-provider

Reviews are very velcome. I am gonna go over it, test a few times, maybe add more error handling. I am creating the PR early to get feedback.

@morpheus65535
Copy link
Owner

Rebase this on development branch please.

@casab casab force-pushed the feature/turkcealtyaziorg_provider branch from 8762c57 to 847036a Compare January 27, 2025 11:04
@casab casab changed the base branch from master to development January 27, 2025 11:05
@casab casab force-pushed the feature/turkcealtyaziorg_provider branch from 847036a to 8deaaf5 Compare January 27, 2025 11:14
@casab
Copy link
Author

casab commented Jan 27, 2025

Sure @morpheus65535, I just created the branch from development again. When rebasing, I had some problems with the history,

Copy link
Owner

@morpheus65535 morpheus65535 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small stuff to modify and we should be good!

@morpheus65535
Copy link
Owner

I'll wait for your get_matches changes to merge this PR. Let me know when you're ready!

@casab
Copy link
Author

casab commented Feb 12, 2025

@morpheus65535 Hey morpheus, can you review it again? I have made all the necessary changes now.

@morpheus65535 morpheus65535 self-requested a review February 13, 2025 03:19
@morpheus65535
Copy link
Owner

@casab it looks really good to me! Great work. Let me know once you ready for me to merge it to dev branch.

@casab
Copy link
Author

casab commented Feb 13, 2025

@morpheus65535 thank you. You can merge it.

@morpheus65535
Copy link
Owner

Maybe one last thing: could you add it to the list of providers in readme?

@casab
Copy link
Author

casab commented Feb 13, 2025

I have already added it when I first created this pr.

@morpheus65535
Copy link
Owner

I have already added it when I first created this pr.

Oh sorry, I should have checked. We forget it most of the time so I just assume. Thanks again!

@morpheus65535 morpheus65535 merged commit 8ff5d58 into morpheus65535:development Feb 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants