-
Notifications
You must be signed in to change notification settings - Fork 249
Added Turkcealtyazi.org provider for Turkish subtitles #2836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Turkcealtyazi.org provider for Turkish subtitles #2836
Conversation
Rebase this on development branch please. |
8762c57
to
847036a
Compare
847036a
to
8deaaf5
Compare
Sure @morpheus65535, I just created the branch from development again. When rebasing, I had some problems with the history, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small stuff to modify and we should be good!
I'll wait for your get_matches changes to merge this PR. Let me know when you're ready! |
@morpheus65535 Hey morpheus, can you review it again? I have made all the necessary changes now. |
@casab it looks really good to me! Great work. Let me know once you ready for me to merge it to dev branch. |
@morpheus65535 thank you. You can merge it. |
Maybe one last thing: could you add it to the list of providers in readme? |
I have already added it when I first created this pr. |
Oh sorry, I should have checked. We forget it most of the time so I just assume. Thanks again! |
After seeing this, I have decided to write it myself;
https://bazarr.featureupvote.com/suggestions/56901/provider-request-add-httpsturkcealtyaziorg-as-provider
Reviews are very velcome. I am gonna go over it, test a few times, maybe add more error handling. I am creating the PR early to get feedback.