-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Jimaku provider #2505
Added Jimaku provider #2505
Conversation
e838ef1
to
24bf0b0
Compare
i'm excited for this PR to merge! Thank you for the work |
a251881
to
8172317
Compare
Reasoning: Subtitle list might update in the meantime
036fe22
to
bbf1f31
Compare
Co-authored-by: Danny <[email protected]>
I'm pretty much okay with the initial implementation of this provider, what you think @morpheus65535 |
It was looking good last time I checked. I'll trust you on this one ;-) |
huge thankyou to @ThisIsntTheWay, i've been following this PR (and associated issue on the Jimaku github requesting Jimaku provider for Bazarr) for a long time and I can't wait for it! @morpheus65535 how often does development branch merge into main? I get my Bazarr release from LinuxServerIO and use their Stable tag release |
@TaakoMagnusen I should be merging dev to master in the upcoming weeks. We normally release a new master approximately every 2 months. |
Adds a new provider for https://jimaku.cc to download Japanese subtitles.
Also adds a new refiner for AniList that resolves AniList IDs by their corresponding AniDB IDs.
ToDos
Features
Support for live action?Reason being that there's no easy way to distinguish Anime vs live action with the metadata that is currently available.
Deal with Anime that have subtitles with absolute episode numbering for cours👉 Possible solution with the AniList API currently being testedanime-relations
to achieve the same goal with good results.Codebase
chs, jpn
|en, ja
)