Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Jimaku provider #2505

Merged
merged 90 commits into from
Aug 6, 2024

Conversation

ThisIsntTheWay
Copy link

@ThisIsntTheWay ThisIsntTheWay commented May 25, 2024

Adds a new provider for https://jimaku.cc to download Japanese subtitles.

Also adds a new refiner for AniList that resolves AniList IDs by their corresponding AniDB IDs.

ToDos

Features

  • Improve series matching accuracy
  • Download and extract from archives
    • Let users prioritize archives over single subtitle files?
  • Let users choose to ignore AI generated subs
  • Extensively test provider with greater sample size
    • E.g. popular shows, older shows, kitsunekko imports
  • Support for live action?
    • An attempt at trying to fetch subtitles will be made, but proper implementation won't be the focus for now.
      Reason being that there's no easy way to distinguish Anime vs live action with the metadata that is currently available.
  • Deal with Anime that have subtitles with absolute episode numbering for cours
    • Tricky to implement. Although we can make use of episode offsets as provided by the AniDB refiner, not all shows have such an attribute.
      • 👉 Possible solution with the AniList API currently being tested
      • ℹ️ Jimakus API now uses erengys anime-relations to achieve the same goal with good results.

Codebase

  • Remake Anilist ID matcher as a refiner
  • Refactor AniDB refiner
  • Adjust subtitle matching
  • Adjust AI subs detection
  • Deal with subs containing multiple languages (such as chs, jpn | en, ja)
  • 429 spam

@ThisIsntTheWay ThisIsntTheWay marked this pull request as draft May 25, 2024 18:56
@TaakoMagnusen
Copy link

i'm excited for this PR to merge! Thank you for the work

@ThisIsntTheWay ThisIsntTheWay marked this pull request as ready for review June 7, 2024 18:44
@ThisIsntTheWay ThisIsntTheWay marked this pull request as draft June 10, 2024 14:10
@ThisIsntTheWay ThisIsntTheWay marked this pull request as ready for review June 16, 2024 20:51
@ThisIsntTheWay ThisIsntTheWay marked this pull request as draft June 21, 2024 21:16
@anderson-oki
Copy link
Collaborator

I'm pretty much okay with the initial implementation of this provider, what you think @morpheus65535

@morpheus65535
Copy link
Owner

I'm pretty much okay with the initial implementation of this provider, what you think @morpheus65535

It was looking good last time I checked. I'll trust you on this one ;-)

@anderson-oki anderson-oki changed the title Add provider: Jimaku Added Jimaku provider Aug 6, 2024
@anderson-oki anderson-oki merged commit 866b1d5 into morpheus65535:development Aug 6, 2024
2 checks passed
@TaakoMagnusen
Copy link

huge thankyou to @ThisIsntTheWay, i've been following this PR (and associated issue on the Jimaku github requesting Jimaku provider for Bazarr) for a long time and I can't wait for it!

@morpheus65535 how often does development branch merge into main? I get my Bazarr release from LinuxServerIO and use their Stable tag release

@morpheus65535
Copy link
Owner

how often does development branch merge into main? I get my Bazarr release from LinuxServerIO and use their Stable tag release

@TaakoMagnusen I should be merging dev to master in the upcoming weeks. We normally release a new master approximately every 2 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants