Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Manually" option for remaining tasks in Settings | Scheduler page #2336

Merged
merged 6 commits into from
Dec 28, 2023

Conversation

JaiZed
Copy link
Collaborator

@JaiZed JaiZed commented Dec 21, 2023

Fix for issue #2330
Made Settings | Scheduler and System | Tasks labels match where appropriate
Removed bleed through of implementation to UI; the user will only see "None" and "Never" for the "Manually" cases in System | Tasks.
Removed obsolete 'sonarr.episodes_sync' from config
Simplified backup code.
Made spelling and capitalization consistent.

Added "Manually" with value of 100 years
Made Settings | Scheduler and System | Tasks labels match where appropriate
Added "Manually" with value of 100 years for Validators
Removed obsolete 'sonarr.episodes_sync'
Removed 2100 "magic year".
All "Manually" tasks are now scheduled for 100 years from now, regardless of being Interval or Cron triggered.
Removed bleed through of implementation to UI; the user will only see "None" and "Never" for the "Manually" cases.
Made spelling and capitalization consistent.
Simplified backup code.
@morpheus65535
Copy link
Owner

image

Some linting remaining. Can you fix that please?

@JaiZed
Copy link
Collaborator Author

JaiZed commented Dec 27, 2023

I was very careful when committing these files to make the changes in place. When I diff them, I don’t see any problem that I can fix.
The only thing I can think of is that I work on Windows and perhaps the git checkout converted all the files to CRLF instead of LF. Most editors handle this automatically but I guess the pretty printer doesn’t.
What is the standard for this project?
I found this link: https://stackoverflow.com/questions/10418975/how-to-change-line-ending-settings
What should I set core.autocrlf to?

To satisfy eslint, also remove now unused episodesSyncOptions references.
@JaiZed
Copy link
Collaborator Author

JaiZed commented Dec 27, 2023

I may have jumped the gun on the CRLF issue. I believe I was misled by the check:fmt
When I ran just npm run check, I saw a now unused variable declared: episodesSyncOptions and not used. That has now been removed everywhere.
I hope the CRLF is not an issue. This last commit will check if it is a problem or not.

A couple were missed during the last cleanup.
@morpheus65535 morpheus65535 merged commit fe52153 into morpheus65535:development Dec 28, 2023
2 checks passed
@JaiZed JaiZed deleted the quiet-hdd branch January 6, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants