Skip to content

Add ChainID to DynamicFeeTx constructor #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WorldDogs merged 1 commit into from
Mar 4, 2025
Merged

Add ChainID to DynamicFeeTx constructor #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tx-submitter/services/rollup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1239,6 +1239,7 @@ func (r *Rollup) ReSubmitTx(resend bool, tx *ethtypes.Transaction) (*ethtypes.Tr
switch tx.Type() {
case ethtypes.DynamicFeeTxType:
newTx = ethtypes.NewTx(&ethtypes.DynamicFeeTx{
ChainID: tx.ChainId(),
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Important fix: Add ChainID to the DynamicFeeTx constructor

This change ensures that when resubmitting a transaction using a DynamicFeeTx, the new transaction inherits the chain ID from the original transaction. This is critical for transaction validity as each transaction must specify the correct blockchain network it's intended for.

The fix appropriately matches the pattern already used for BlobTx at line 1254 where the chain ID is also inherited from the original transaction.

To: tx.To(),
Nonce: tx.Nonce(),
GasFeeCap: gasFeeCap,
Expand Down