Skip to content

Check genesis batch is zero #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chengwenxi merged 1 commit into from
Nov 21, 2024
Merged

Check genesis batch is zero #646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions contracts/contracts/l1/rollup/Rollup.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,8 @@ contract Rollup is IRollup, OwnableUpgradeable, PausableUpgradeable {

(uint256 memPtr, bytes32 _batchHash) = _loadBatchHeader(_batchHeader);
uint256 _batchIndex = BatchHeaderCodecV0.getBatchIndex(memPtr);
// check batch index is 0
require(_batchIndex == 0, "invalid batch index");
bytes32 _postStateRoot = BatchHeaderCodecV0.getPostStateHash(memPtr);
require(_postStateRoot != bytes32(0), "zero state root");
// check all fields except `dataHash` and `lastBlockHash` are zero
Expand Down
9 changes: 9 additions & 0 deletions contracts/contracts/test/Rollup.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,15 @@ contract RollupTest is L1MessageBaseTest {
function test_importGenesisBlock_succeeds() public {
bytes memory batchHeader;
bytes32 bytesData1 = bytes32(uint256(1));
// invalid batch index, revert
batchHeader = new bytes(249);
assembly {
mstore(add(batchHeader, add(0x20, 1)), shl(192, 1)) // batchIndex = 1
}
hevm.expectRevert("invalid batch index");
hevm.prank(multisig);
rollup.importGenesisBatch(batchHeader);

// zero state root, revert
batchHeader = new bytes(249);
hevm.expectRevert("zero state root");
Expand Down