Skip to content

create copy of variables used in loop #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FletcherMan merged 1 commit into from
Mar 28, 2024
+4 −2
Merged

create copy of variables used in loop #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion node/derivation/batch_info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ func (bi *BatchInfo) ParseBatch(batch geth.RPCRollupBatch) error {
bi.version = uint64(batch.Version)
var txPayload []byte
for _, blob := range batch.Sidecar.Blobs {
data, err := types.DecodeRawTxPayload(&blob)
blobCopy := blob
data, err := types.DecodeRawTxPayload(&blobCopy)
if err != nil {
return err
}
Expand Down
3 changes: 2 additions & 1 deletion node/derivation/derivation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,8 @@ func (d *Derivation) derive(rollupData *BatchInfo) (*eth.Header, error) {
var lastHeader *eth.Header
for _, chunk := range rollupData.chunks {
for _, blockData := range chunk.blockContextes {
blockData.SafeL2Data.BatchHash = &rollupData.batchHash
batchHash := rollupData.batchHash
blockData.SafeL2Data.BatchHash = &batchHash
latestBlockNumber, err := d.l2Client.BlockNumber(context.Background())
if err != nil {
return nil, fmt.Errorf("get derivation geth block number error:%v", err)
Expand Down