Skip to content

fix(primitives): return baseFee as effectiveGasPrice for L1 messages #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
panos-xyz merged 2 commits into from
Mar 26, 2026
Merged

fix(primitives): return baseFee as effectiveGasPrice for L1 messages #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e60cd8
fix(primitives): return baseFee as effectiveGasPrice for L1 messages
panos-xyz Mar 26, 2026
c349cfe
Merge branch 'main' into fix/l1-msg-effective-gas-price
panos-xyz Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions crates/primitives/src/transaction/l1_transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,10 @@ impl Transaction for TxL1Msg {
0
}

fn effective_gas_price(&self, _base_fee: Option<u64>) -> u128 {
0
fn effective_gas_price(&self, base_fee: Option<u64>) -> u128 {
// L1 messages are prepaid on L1 and have no gas price themselves.
// Return baseFee as the effective gas price to match go-ethereum behavior.
base_fee.unwrap_or(0) as u128
}

fn is_dynamic_fee(&self) -> bool {
Expand Down Expand Up @@ -366,7 +368,8 @@ mod tests {
assert_eq!(tx.max_priority_fee_per_gas(), None);
assert_eq!(tx.max_fee_per_blob_gas(), None);
assert_eq!(tx.priority_fee_or_price(), 0);
assert_eq!(tx.effective_gas_price(Some(100)), 0);
assert_eq!(tx.effective_gas_price(Some(100)), 100); // returns baseFee for receipts
assert_eq!(tx.effective_gas_price(None), 0); // no baseFee → 0 (execution path)
assert!(!tx.is_dynamic_fee());
assert!(!tx.is_create()); // L1 messages can never create contracts
assert_eq!(
Expand Down
Loading