Skip to content

fix(serde): add default for TxMorph version/feeTokenId/feeLimit fields #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chengwenxi merged 2 commits into from
Mar 11, 2026
Merged

fix(serde): add default for TxMorph version/feeTokenId/feeLimit fields #44

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
045269c
fix(serde): add default for TxMorph version/feeTokenId/feeLimit fields
chengwenxi Mar 11, 2026
564f375
fix(serde): mirror defaults on MorphTxFields and add serde regression…
chengwenxi Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/primitives/src/transaction/morph_transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,16 +109,17 @@ pub struct TxMorph {

/// Version of the Morph transaction format.
/// Used for future extensibility.
#[cfg_attr(feature = "serde", serde(with = "alloy_serde::quantity"))]
#[cfg_attr(feature = "serde", serde(default, with = "alloy_serde::quantity"))]
pub version: u8,

/// Token ID for alternative fee payment.
/// This corresponds to the token registered in the L2 Token Registry.
/// 0 means ETH payment, > 0 means ERC20 token payment.
#[cfg_attr(feature = "serde", serde(with = "alloy_serde::quantity"))]
#[cfg_attr(feature = "serde", serde(default, with = "alloy_serde::quantity"))]
pub fee_token_id: u16,

/// Maximum amount of tokens the sender is willing to pay as fee.
#[cfg_attr(feature = "serde", serde(default))]
pub fee_limit: U256,
Comment thread
coderabbitai[bot] marked this conversation as resolved.

/// Reference key for the transaction (optional, v1 only).
Expand Down