fix(zktrie): add max recursion depth limit to countLeaves#286
Merged
curryxbo merged 1 commit intofeat/zktrie2mptfrom Feb 9, 2026
Merged
fix(zktrie): add max recursion depth limit to countLeaves#286curryxbo merged 1 commit intofeat/zktrie2mptfrom
curryxbo merged 1 commit intofeat/zktrie2mptfrom
Conversation
Add maxZkTrieDepth (256) constant and depth check in countLeaves function to prevent potential stack overflow, node crashes, and DoS attacks. The theoretical maximum depth of zkTrie is 256, so this limit ensures safe recursion while covering all valid use cases.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1f36467 to
efda8bb
Compare
panos-xyz
added a commit
that referenced
this pull request
Feb 11, 2026
* feat: change zktrie to mpt * fix: add diskroot mapping for consensus api new L2 block * fix: fixed alttxfee stroage trace in mpt mode * refactor: remove useless block trace struct fields * refactor: retain executionResults in blocktrace but remove structlog * fix: fixed ci code scanning alerts * feat: add eth_config with morph extension * feat: add mptForkTime override flag * fix: fixed getblockTrace stateroot mismatch * Update AssembleL2Block (#259) * update AssembleL2BlockParams --------- Co-authored-by: corey <corey.zhang@bitget.com> * feat:Add migration-checker (#271) * update AssembleL2BlockParams * update ec clent * add migration-checker * add gen preimages * clean changes * optimize“ * update readme“ * clean readme“ * clean trie changes --------- Co-authored-by: corey <corey.zhang@bitget.com> * limit AssembleL2Block (#285) * limit AssembleL2Block * fmt --------- Co-authored-by: corey <corey.zhang@bitget.com> * fix(zktrie): add max recursion depth limit to countLeaves (#286) Add maxZkTrieDepth (256) constant and depth check in countLeaves function to prevent potential stack overflow, node crashes, and DoS attacks. The theoretical maximum depth of zkTrie is 256, so this limit ensures safe recursion while covering all valid use cases. Co-authored-by: corey <corey.zhang@bitget.com> * Add Progress bar (#280) * add progress bar * clean default value * fix --------- Co-authored-by: corey <corey.zhang@bitget.com> --------- Co-authored-by: corey <coreyx1992@gmail.com> Co-authored-by: corey <corey.zhang@bitget.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add maxZkTrieDepth (256) constant and depth check in countLeaves function to prevent potential stack overflow, node crashes, and DoS attacks.
The theoretical maximum depth of zkTrie is 256, so this limit ensures safe recursion while covering all valid use cases.
1. Purpose or design rationale of this PR
...
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?