Skip to content

Add rate and scale check #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kukoomomo merged 2 commits into from
Dec 22, 2025
Merged

Add rate and scale check #273

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
768898d
add rate and scale check
Kukoomomo Dec 22, 2025
64e9dcd
fix
Kukoomomo Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions rollup/fees/rate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,17 @@ func TokenRate(state StateDB, tokenID uint16) (*big.Int, *big.Int, error) {
log.Error("Invalid token address", "tokenID", tokenID)
return nil, nil, errors.New("invalid token address")
}

// If price is nil or zero, this token doesn't have a valid price
if rate == nil || rate.Sign() == 0 {
log.Error("Invalid token price", "tokenID", tokenID, "tokenAddr", info.TokenAddress.Hex())
return nil, nil, err
}
Comment thread
Kukoomomo marked this conversation as resolved.

if info.Scale == nil || info.Scale.Sign() == 0 {
log.Error("Invalid token scale", "tokenID", tokenID, "tokenAddr", info.TokenAddress.Hex())
return nil, nil, err
}
Comment thread
Kukoomomo marked this conversation as resolved.
return rate, info.Scale, nil
}

Expand Down