[R-4]Fix variable name

[curryxbo]

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
• ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
• docs: Documentation-only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
• test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

• This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change
• Yes

Summary by CodeRabbit

• Bug Fixes
  • Fixed a variable naming issue in fee rate calculations that could have caused incorrect transaction fee computations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Fixed a typo in the rollup/fees/rate.go file where a local variable name was corrected from tokenSacle to tokenScale, and the corresponding function call was updated to reference the corrected variable name.

Changes

Cohort / File(s)	Summary
Variable naming correction rollup/fees/rate.go	Fixed typo in local variable name from tokenSacle to tokenScale in the EthToAlt function and updated the TokenRate function call to use the corrected variable.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• Fix err return when token info invalid #261: Addresses the same tokenScale variable typo in the EthToAlt function and its corresponding TokenRate call.

Suggested reviewers

• secmgt
• FletcherMan
• tomatoishealthy

Poem

🐰 A rabbit hops through the code with glee,
Finding a typo—Sacle → Scale, you see!
One little letter was out of place,
Now variables bloom with proper grace. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title '[R-4]Fix variable name' directly corresponds to the main change: fixing a typo in variable naming from tokenSacle to tokenScale in the EthToAlt function.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-variablename

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9217e7b and 74ed6a9.

📒 Files selected for processing (1)

• rollup/fees/rate.go (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-11-10T06:56:24.937Z

Learnt from: Kukoomomo
Repo: morph-l2/go-ethereum PR: 205
File: core/token_gas.go:140-155
Timestamp: 2025-11-10T06:56:24.937Z
Learning: In the ERC20 fee implementation (core/token_gas.go), ERC20 transfer and balance check calls use math.MaxUint64 gas limit. This is intentional given that fee tokens are restricted to an allowlist (via IsTokenActive checks and AllowListSlot/AllowListEnabledSlot in rollup/rcfg/config.go), so only vetted contracts can be invoked. The team has chosen this approach understanding the tradeoffs versus adding fixed gas stipends.

Applied to files:

• rollup/fees/rate.go

🧬 Code graph analysis (1)

rollup/fees/rate.go (1)

core/types/token_fee.go (1)

• EthToAlt (52-66)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (go)

🔇 Additional comments (1)

rollup/fees/rate.go (1)

30-36: LGTM! Typo fix correctly applied.

The variable name correction from tokenSacle to tokenScale is properly applied in both the declaration (line 31) and usage (line 35). This brings the EthToAlt function in line with the AltToETH function below, which already uses the correct spelling.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}