Skip to content

Fix err return when token info invalid #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kukoomomo merged 3 commits into from
Dec 16, 2025
Merged

Fix err return when token info invalid #261

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccf8e4e
fix err return when token info invalid
Kukoomomo Dec 16, 2025
13b8ea0
update
Kukoomomo Dec 16, 2025
210a32f
fix exchange rate conversion
Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions rollup/fees/rate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,22 @@ func TokenRate(state StateDB, tokenID uint16) (*big.Int, *big.Int, error) {

if info.Scale == nil || info.Scale.Sign() == 0 {
log.Error("Invalid token scale", "tokenID", tokenID, "tokenAddr", info.TokenAddress.Hex())
return nil, nil, errors.New("invalid token scale")
}

// If token address is zero, this is not a valid token
if info.TokenAddress == (common.Address{}) {
log.Error("Invalid token address", "tokenID", tokenID)
return nil, nil, err
return nil, nil, errors.New("invalid token address")
}

// If price is nil or zero, this token doesn't have a valid price
if rate == nil || rate.Sign() == 0 {
log.Error("Invalid token price", "tokenID", tokenID, "tokenAddr", info.TokenAddress.Hex())
return nil, nil, err
return nil, nil, errors.New("invalid token price")
}

return rate, info.Scale, err
return rate, info.Scale, nil
}

func EthToAlt(state StateDB, tokenID uint16, amount *big.Int) (*big.Int, error) {
Expand Down