Skip to content

Revert changes#251

Merged
curryxbo merged 1 commit intomainfrom
revertChanges
Nov 20, 2025
Merged

Revert changes#251
curryxbo merged 1 commit intomainfrom
revertChanges

Conversation

@curryxbo
Copy link
Copy Markdown
Contributor

@curryxbo curryxbo commented Nov 20, 2025

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

Summary by CodeRabbit

  • Chores
    • Internal code optimizations and cleanup to improve maintainability

Note: This release contains only internal improvements with no user-facing changes or new functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

@curryxbo curryxbo requested a review from a team as a code owner November 20, 2025 07:22
@curryxbo curryxbo requested review from tomatoishealthy and removed request for a team November 20, 2025 07:22
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 20, 2025

Walkthrough

Two minor code cleanup changes across fee pricing modules: simplified variable declaration in gas fee history processing and removal of commented-out code in GraphQL transaction pricing logic. No functional behavior modifications.

Changes

Cohort / File(s) Summary
Variable declaration simplification
eth/gasprice/feehistory.go
Combined separate initialization and assignment of the reward variable into a single short variable declaration with tx.EffectiveGasTip() call. Stylistic refactor preserving identical runtime behavior.
Comment cleanup
graphql/graphql.go
Removed commented-out annotation lines in Transaction.GasPrice method for AltFeeTxType. Existing active logic for fee calculation remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Both changes are non-functional code maintenance:

  • Variable declaration simplification in feehistory.go is a straightforward Go idiom consolidation with no logic changes
  • Comment removal in graphql.go is purely cosmetic cleanup with zero impact on behavior

Poem

🐰 A hop, a skip, a line made neat,
Comments gone, declarations sweet!
Cleaner code, more elegant still,
Refactoring with a gentle will.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title 'Revert changes' is vague and generic, failing to specify what changes are being reverted or why, making it unclear for history scanning. Replace with a specific, descriptive title following Conventional Commits format (e.g., 'refactor: simplify variable declaration in processBlock' or 'refactor: remove commented code in Transaction.GasPrice').
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revertChanges

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 50a6bbb and d7c04f8.

📒 Files selected for processing (2)
  • eth/gasprice/feehistory.go (1 hunks)
  • graphql/graphql.go (0 hunks)
💤 Files with no reviewable changes (1)
  • graphql/graphql.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (go)
🔇 Additional comments (1)
eth/gasprice/feehistory.go (1)

123-123: LGTM! Cleaner variable declaration.

The simplified short variable declaration is more idiomatic Go and removes the unnecessary zero initialization that was immediately overwritten.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@curryxbo curryxbo merged commit adf5a14 into main Nov 20, 2025
8 checks passed
@curryxbo curryxbo deleted the revertChanges branch November 20, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants