Skip to content

fix: Address fee mismatch issue in L1DataFee settlement#208

Merged
FletcherMan merged 1 commit intofeat/eip-7702from
fix/settle_fee_mismatch
Oct 17, 2025
Merged

fix: Address fee mismatch issue in L1DataFee settlement#208
FletcherMan merged 1 commit intofeat/eip-7702from
fix/settle_fee_mismatch

Conversation

@FletcherMan
Copy link
Copy Markdown
Collaborator

1. Purpose or design rationale of this PR

This PR fixes a critical issue in the fee settlement logic that could lead to token inflation when FeeVault is disabled.

The fix modifies the fee calculation in TransitionDb() to only include L1DataFee in the total fee sent to the recipient when FeeVault is enabled, ensuring consistency with the buyGas() function.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@FletcherMan FletcherMan requested a review from a team as a code owner October 16, 2025 06:41
@FletcherMan FletcherMan requested review from r3aker86 and removed request for a team October 16, 2025 06:41
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 16, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/settle_fee_mismatch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FletcherMan FletcherMan merged commit 7fab3d1 into feat/eip-7702 Oct 17, 2025
1 check passed
@FletcherMan FletcherMan deleted the fix/settle_fee_mismatch branch October 17, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant