Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latest ndk r25c #254

Closed
wants to merge 2 commits into from
Closed

latest ndk r25c #254

wants to merge 2 commits into from

Conversation

pelya
Copy link
Collaborator

@pelya pelya commented May 7, 2023

No description provided.

@pelya
Copy link
Collaborator Author

pelya commented May 7, 2023

How do I review my own PR?

justusranvier
justusranvier approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@justusranvier justusranvier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems weird to me that github is giving me the option to review this but since it showed up in my notifications I guess I'll see what happens.

@pelya
Copy link
Collaborator Author

pelya commented May 8, 2023

Nope, Github won't let me merge this, it needs someone with write access to review the PR.

@justusranvier
Copy link
Contributor

@pelya Do you just need someone else to open an identical PR so that you can review and merge it?

@justusranvier justusranvier mentioned this pull request May 17, 2023
Merged
@pelya
Copy link
Collaborator Author

pelya commented May 18, 2023

Merged in another PR

@pelya pelya closed this May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusranvier justusranvier justusranvier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pelya @justusranvier