-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failure v2 #50
Merged
failure v2 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check
docs/v1-to-v2.md
for migration.If there were something unclear or found issues, feel free to open issue or contact me on X https://twitter.com/inukirom.
What's New
Remarkable changes with
v2
.Simple error chain structure
v2
has only one struct to wrap errors rather than wrapping errors for each wrapper struct.In
v1
error chain structure was likeBut in
v2
error chain structure will be likeSo no longer need wrapping too much times for each additional data.
You can simply add any key-value data in failure.
Arbitrary error code type
v1
had been requestedCode
interface for error codes:But now, any
comparable
types can be used as error code inv2
:So, you can use gRPC error code
google.golang.org/grpc/codes
with failure!