Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed entry status icon - status category mapping on webUI #1160

Merged
merged 2 commits into from
Dec 12, 2024
+3 −1
Merged

Fixed entry status icon - status category mapping on webUI #1160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bb6906
Fixed entry status icon - status category mapping on webUI
rnemes Dec 11, 2024
91482d6
Merge branch 'main' into xfail
rnemes Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/newsfragments/3170_changed.status_icon_xfail.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed an issue where enabling Status icons crashed the report when a test was marked as XFAIL.
3 changes: 2 additions & 1 deletion testplan/web_ui/testing/src/Nav/navUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import TagList from "./TagList";
import Column from "./Column";
import CommonStyles, { statusStyles } from "../Common/Styles.js";
import { STATUS_CATEGORY } from "../Common/defaults.js";
import { navStyles } from "../Common/Styles";
import {
generateURLWithParameters,
Expand Down Expand Up @@ -304,7 +305,7 @@ const GetStatusIcon = (status) => (
<FontAwesomeIcon
title={status}
size="sm"
icon={statusStyles[status].icon}
icon={statusStyles[STATUS_CATEGORY[status]].icon}
className={css(navStyles.icon)}
/>
</span>
Expand Down
Loading