Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat, refactor]: add eslint import order rules, refactor import order #301

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

yoosion030
Copy link

@yoosion030 yoosion030 commented Nov 6, 2023

Description

While looking at the code, I saw that the relative path and order were not organized in the import code.

So we added a function to organize the order. The following changes were made to add this function:

  1. Add path attribute to tsconfig file to prevent src/ path from being overused.
    src/components -> @/components
  2. Add rules to .eslintrc.json for organize import order

before
스크린샷 2023-11-06 오후 4 19 29

after
스크린샷 2023-11-06 오후 4 19 47

You may be reluctant to merge because there are a lot of file changes, but the following problems can be improved with these changes:

  • Unification of code styles of multiple contributors
  • Replace relative paths with path aliases ->
    Match code style even when file path changes

It is for this benefit that I request the change.

PR Checklist

Copy link

vercel bot commented Nov 6, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @morethanmin on Vercel.

@morethanmin first needs to authorize it.

@morethanmin morethanmin self-requested a review November 6, 2023 14:43
Copy link
Owner

@morethanmin morethanmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요! 아래 커밋은 제외하고 PR 부탁드립니다. (해당 PR과 관련없는 커밋)

감사합니다 ㅎㅎ

@yoosion030
Copy link
Author

안녕하세요! 아래 커밋은 제외하고 PR 부탁드립니다. (해당 PR과 관련없는 커밋)

감사합니다 ㅎㅎ

아아 다른 PR에 올린 커밋이 포함되었네요,, 수정해서 다시 업로드 하겠습니다!

@yoosion030
Copy link
Author

@morethanmin 수정했습니다 :)

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
morethan-log ❌ Failed (Inspect) Dec 18, 2023 1:18am

@morethanmin morethanmin self-requested a review November 23, 2023 02:39
Copy link
Owner

@morethanmin morethanmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

늦게 리뷰 드려서 죄송합니다 ㅠㅠ 빌드오류가 발생해서 한번 확인 부탁드리겠습니다. 감사합니다!

@morethanmin morethanmin self-requested a review December 17, 2023 05:42
Copy link
Owner

@morethanmin morethanmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아직 빌드오류가 발생하는 것 같아 로컬에서 한번 잡아주시면 좋을 것 같습니다.

감사합니다!

@morethanmin morethanmin self-requested a review December 24, 2023 11:01
Copy link
Owner

@morethanmin morethanmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@yoosion030
Copy link
Author

네, 다시 한번 확인해보겠습니다 :)

@morethanmin
Copy link
Owner

@yoosion030

해당 PR 제가 이어서 작업하겠습니다 ~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants