Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-verbose mode as default #38

Closed
jayvdb opened this issue Dec 30, 2019 · 5 comments
Closed

Non-verbose mode as default #38

jayvdb opened this issue Dec 30, 2019 · 5 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Dec 30, 2019

The yehua output contains:

Requirement already satisfied: pypi-mobans-pkg==0.0.7 in /home/python3.7/lib/python3.7/site-packages (0.0.7)
Requirement already satisfied: lml in /home/python3.7/lib/python3.7/site-packages (from pypi-mobans-pkg==0.0.7) (0.0.9)

IMO that is unnecessary except in a verbose mode, which shouldnt be default.

Also I dont see how it is beneficial for a moban template pkg to include lml , as moban already depends on it, so it should already exist..?

@chfw
Copy link
Member

chfw commented Dec 30, 2019

With hindsight, it should not depend on lml

@jayvdb
Copy link
Member Author

jayvdb commented Dec 31, 2019

Also I see Warning: 'requires' is deprecated since 0.6.0! Please use pypi:// or git:// notation instead , but I think I am using the latest yehua and moban and pypi-moban-pkg.
Something somewhere must be using old syntax...?

@chfw
Copy link
Member

chfw commented Dec 31, 2019

Yes, moban file needs updating

chfw added a commit that referenced this issue Jan 1, 2020
@chfw
Copy link
Member

chfw commented Jan 14, 2020

the following legacy code exists in the library. That's why lml was listed. With pypifs, lml related code shall exist the stage.

# flake8: noqa
import os
from pypi_mobans_pkg._version import __version__
from pypi_mobans_pkg._version import __author__
from lml.plugin import PluginInfo


@PluginInfo('library', tags=['setupmobans', 'pypi', 'pypi-mobans-pkg'])
class Pypkg():
    def __init__(self):
        __package_path__ = os.path.dirname(__file__)
        self.resources_path = os.path.join(
            __package_path__, "resources")

the only plus point is: pypi-mobans-pkg will support older version of moban < 0.6.0.

@chfw
Copy link
Member

chfw commented May 3, 2020

above code has been removed in pypi-moban-pkg 0.0.13, so such legacy use is gone forever.

https://travis-ci.org/github/moremoban/moban/jobs/682686615

@chfw chfw closed this as completed May 13, 2020
chfw added a commit that referenced this issue May 17, 2020
* ✨ non-verbose mode. #38

* 📚update shell instructions

* 🔨 refactor yehua's own template

* :sparkles; update coding style

* 💚 yehua.yml is now able to have default values and jinja2 template too. #49

* 📚 update text info

* This is an auto-commit

Co-authored-by: chfw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants