Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit targets with template extensions default to copy #322

Closed
jayvdb opened this issue Aug 24, 2019 · 2 comments
Closed

Implicit targets with template extensions default to copy #322

jayvdb opened this issue Aug 24, 2019 · 2 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Aug 24, 2019

foo.jj2: foo.jj2 could default to copy.

For coala , and the other times I have implemented moban, this and binary files are only time that the copy: section was necessary.
@jayvdb jayvdb mentioned this issue Aug 24, 2019
Closed
@chfw
Copy link
Member

chfw commented Aug 24, 2019

This looks like a rule that if target file extension is the same as source, it is copy unless template engine is explicitly expressed.

@jayvdb
Copy link
Member Author

jayvdb commented Aug 24, 2019

yup, that sounds good.

chfw added a commit that referenced this issue Sep 11, 2019
@chfw
✨ nice add-on for implicit target syntax. resolves #322
1a3f0fe
@chfw chfw changed the title Targets with template extensions default to copy Implicit targets with template extensions default to copy Sep 11, 2019
@chfw chfw mentioned this issue Sep 11, 2019
Merged
4 tasks
@chfw chfw closed this as completed in ec337d4 Sep 12, 2019
chfw added a commit that referenced this issue Oct 6, 2019
@chfw
📚 add migration notes. #322
5715933
chfw added a commit that referenced this issue Oct 7, 2019
@chfw
Code refactoring (#340)
5a5c980 
* 📚 add migration notes. #322

* 🚜 relocate files for coherence

* 🚜 relocated plugins.py

* 🚜 grouped all plugins to plugins directory

* 🚜 relocated data loader manager to core folder

* 🚜 relocated definitions to core folder

* 🚜 relocated hashstore to core folder

* 💚 enable plugins to be found as module

* 👕 update coding style

* 💚 update hardcode references

* 🚜 relocate utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayvdb @chfw