Skip to content

[Feat] ShareGPT input len - #4

Closed
jiminpark-moreh wants to merge 1 commit into
mainfrom
sharegpt_input_len
Closed

jiminpark-moreh wants to merge 1 commit into
mainfrom
sharegpt_input_len

Conversation

@jiminpark-moreh

@jiminpark-moreh jiminpark-moreh commented Dec 8, 2025 •

Copy link
Copy Markdown
Collaborator

Purpose

Add ShareGPT input len option.

The ShareGPT dataset uses pre-built questions as prompts, so the input length varies for each request. Since we need performance with uniform input sequence length, we added an input length option to ShareGPT. When --sharegpt-input-len is specified, new input is created by concatenating existing questions into a single prompt.

Test Plan

vllm bench serve \
  --backend vllm \
  --model "deepseek-ai/DeepSeek-R1" \
  --metric-percentiles "90" \
  --percentile-metrics "itl,tps,ttft,e2el" \
  --host "mif-istio.cluster.svc.cluster.local" \
  --port 80 \
  --num-prompts 32400 \
  --max-concurrency 10800 \
  --request-rate 78 \
  --ignore-eos \
  --ready-check-timeout-sec 0 \
  --max-connections-per-worker 1296 \
  --dataset-name sharegpt \
  --dataset-path /app/dataset/ShareGPT_V3_unfiltered_cleaned_split.json \
  --sharegpt-input-len 1000 \
  --sharegpt-output-len 1000

Test Result

  1. Creating new prompts on benchmark
[3240/32400] new prompts are created
[6480/32400] new prompts are created
[9720/32400] new prompts are created
INFO 12-08 06:51:23 [datasets.py:245] Oversampled requests to reach 32400 total samples.
...
  1. On benchmark result, "Total input tokens" will be the number of num-prompts x sharegpt-input-len
============ Serving Benchmark Result ============
Number of worker processes:              25
Successful requests:                     32400
Maximum request concurrency:             10800
Request rate configured (RPS):           80.00
Benchmark duration (s):                  636.88
Total input tokens:                      32400000
Total generated tokens:                  32400000
...

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@jiminpark-moreh jiminpark-moreh changed the title ShareGPT input len [Feat] ShareGPT input len Dec 8, 2025
hgquannn added a commit that referenced this pull request Sep 21, 2026
…se branch

Brings the changes tested on the tmp/v0.28.0 image series into moreh/v0.28.0.
Content is exactly that of the fork PRs #16 to #22 (all against this branch
or its tmp copy):

  #16  [ROCm][Perf] Fuse DSA indexer QK preprocessing with AITER (upstream vllm-project#53094)
  #17  [ROCm][Perf] Shard DSA prefill indexer rows across TP ranks (upstream vllm-project#56944)
  #18  [ROCm] Skip redundant sparse index remap on non-indexer layers
       (backport of upstream vllm-project/vllm vllm-project#51309)
  #19  [ROCm][MLA][Perf] Fuse decode QK-RoPE + Q-concat + KV-concat + KV-cache
       write for sparse MLA (backport of upstream vllm-project#47757)
  #20  [ROCm][Perf] Dispatch DSA prefill indexer logits to aiter's HIP kernel on gfx950
  #21  [ROCm][Perf] Use AITER tuned GEMM for the MoE router gate
       (backport of upstream vllm-project#50535)
  #22  [ROCm][Bugfix] Add `positions` to unified_mla_attention_with_output_fake

Verified as image vllm-forks:0.28.0-pr16-21-a4-9-260917 (this branch minus #22)
built with aiter moreh/v0.1.19 + PR #4 + PR #9 on MI355X.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant