Conversation
`AutoMocker.Use` previously used value equality (`Equals`) when checking if an object instance had already been registered. This led to an `InvalidOperationException` when distinct object instances that were value-equal (e.g., `Uri` objects or C# records with the same property values) were provided. This change updates the check to use `ReferenceEquals`, ensuring that the exception is only thrown when the exact same object instance is added multiple times, not merely value-equal instances. Fixes #470.
Keboo
enabled auto-merge (squash)
August 12, 2026 07:00
This was referenced Aug 28, 2026
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoMocker.Usepreviously used value equality (Equals) when checking if an object instance had already been registered. This led to anInvalidOperationExceptionwhen distinct object instances that were value-equal (e.g.,Uriobjects or C# records with the same property values) were provided.Fixes: #470
This change updates the check to use
ReferenceEquals, ensuring that the exception is only thrown when the exact same object instance is added multiple times, not merely value-equal instances.Fixes #470.