-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support musicbrainz fields in search and distinct #43
Support musicbrainz fields in search and distinct #43
Conversation
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=======================================
Coverage 50.39% 50.39%
=======================================
Files 9 9
Lines 764 764
=======================================
Hits 385 385
Misses 379 379
Continue to review full report at Codecov.
|
5246222
to
aacc738
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I don't have any experience with SQLite migrations either.
@kingosticks: I'm pretty impressed you could actually make some sense out of this mess ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks fine, but I'd also suggest updating schema.sql
accordingly.
BTW, since v5 was the first sqlite schema version used in |
Ahh, I didn't notice that |
A fix for #42. My first attempt at using SQLite, hope I did the migration correctly.
This requires mopidy/mopidy#1900