Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature allow changing caching strategy #59

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

keshavkaul
Copy link

@keshavkaul keshavkaul commented Aug 3, 2023

Motivation:

  1. I'm using Easycaching.Redis as caching provider, and I'm getting the error in CachingReader class when trying to cast a DBNull value into a primitive type like string.
  2. I want to change the CachedResult type into a more json/messagepack serializer friendly class.
  3. I want to try using DataTable.CreateDataReader as the data reader instead of CachingReader.

I've tried to be backwards compatible.
Request you to accept this PR or provide any comments on improvement.

Thank you for creating this library. I'm open to contribute a small amount if you're okay with it.

CachingCommandStrategy should not have access to ExecuteDbDataReader
Rename _command to _commandMetadata
@keshavkaul keshavkaul force-pushed the feature/allow-changing-caching-strategy branch from c1520b4 to afafafd Compare August 4, 2023 10:49
…endence on feature/use-generic-cache-interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant