[Famix-Java] mooseNameOn: on Java inner class does not include $

[alkalinan]

problem description

In Java, the full qualify name of a class includes an $ symbol in front of inner java class name. Consequently, when comparing a method signature from the JVM with signature generated from a Famix Moose java model (e.g. with mooseNameWithDots); the two signatures do not match.

"example: "
model := MooseModel root first.
inner := (model allModelClasses detect: #isInnerClass).
inner  mooseNameWithDots
"'fr.magnus.ucbondecommande.ihmintranet.fiche.OngletIdentification.AchatGrilleListener'"

"instead of (from Java)"
"'fr.magnus.ucbondecommande.ihmintranet.fiche.OngletIdentification$AchatGrilleListener'"

proposed solution

my solution is 'hacky', because moose name are store in cache, I've changed the method mooseNameWithDots and mooseNameOn

mooseNameWithDots

	self resetMooseName.
	^ self mooseName ifNotNil: [ '.' join: (self mooseName substrings: '::') ].

The 'hack' is to resetMooseName each time to be sure that it is now store properly.

FamixTType::FamixJavaClass::mooseNameOn: aStream

	self typeContainer
		ifNotNil: [ :parent |
			|separator|
			separator := '::'.
			self isInnerClass ifTrue: [ separator := '$' ].
			parent mooseNameOn: aStream.
			aStream nextPutAll: separator  ].
	self name ifNotNil: [ :n | aStream nextPutAll: n ]

This solution works but may causes compatibility issues.

(my first famix issue 🤓 )