[WIP] Add immutable number #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The immutable object is usefull if you want to display a price without changing the object itself. $product->getUnitPrice()->mul($quantity = 4) ... |
|
@ramsey Any comment on this PR ? I will add unit test on the class if you are agree on the change. By the way the changes are BC |
|
I had to take time to review the changes, and it looked like there were a lot of them, but that's just because of all the whitespace changes. Everything looks good. Please add the unit test, and I'll merge in the changes. Thanks for contributing this! |
|
Thanks for the feedback, I will do the unit test ASAP. Thanks |
|
@rande any update on this? I'd very much like this functionality. If you don't have the time let me know, I could pick this up. |
peter279k
pushed a commit
to peter279k/math-3
that referenced
this pull request
May 22, 2018
php 7.0 unit tests fixes - correct octal numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.