fix: Audit 02/24 by milesj · Pull Request #2384 · moonrepo/moon

milesj · 2026-02-25T18:05:37Z

No description provided.

Copilot

Pull request overview

This PR applies an audit sweep across Moon’s CLI/runtime (Rust), visualizer (TS), config/docs, and test fixtures to address CI/task execution behavior, graph visualization compatibility, and a few operational/debuggability concerns.

Changes:

Switch graph serving/rendering to use the raw GraphToJson JSON format (pretty for --json, compact for the server), and update the visualizer to handle the newer graph shape.
Refine task-building behavior around runInCI defaults and shell auto-detection (respect shell: false for glob/env detection), with added fixtures/tests.
Add defaults for hasher.ignoreMissingPatterns, add MOON_INCLUDE_RELATIONS env support for --include-relations, add more docker prune debug logs, and temporarily relax shallow-checkout CI behavior.

Reviewed changes

Copilot reviewed 24 out of 25 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
yarn.lock	Adds workspace dependency resolution for visualizer → types.
website/docs/config/workspace.mdx	Documents default `hasher.ignoreMissingPatterns` behavior.
packages/visualizer/package.json	Adds `@moonrepo/types` dependency.
packages/visualizer/tsconfig.json	Adds TS project reference to `../types`.
packages/visualizer/src/helpers/types.ts	Introduces v1/v2 graph type union aligned with `@moonrepo/types`.
packages/visualizer/src/helpers/render.ts	Adds v2 graph extraction + action label rendering.
crates/graph-utils/src/graph_formats.rs	Makes `GraphToJson::to_json` accept a `pretty` toggle.
crates/app/src/commands/action_graph.rs	Uses `to_json(true/false)` for JSON output vs server payload.
crates/app/src/commands/project_graph.rs	Uses `to_json(true/false)` for JSON output vs server payload.
crates/app/src/commands/task_graph.rs	Uses `to_json(true/false)` for JSON output vs server payload.
crates/app/src/commands/graph/utils.rs	Serves already-serialized JSON directly to the UI/server.
crates/app/src/commands/graph/mod.rs	Removes DTO module export, leaving only server utilities.
crates/app/src/commands/graph/dto.rs	Removes the legacy DTO-based graph representation.
crates/task/src/task.rs	Extends `TaskState` and updates CI run decision logic.
crates/task-builder/src/tasks_builder.rs	Tracks new task state flags, adjusts default `runInCI`, and shell auto-detection.
crates/task-builder/tests/tasks_builder_test.rs	Updates shell expectations + adds tests for auto-shell and runInCI behavior.
crates/task-builder/tests/fixtures/builder/syntax/moon.yml	Updates fixtures to rely on auto-shell behavior.
crates/task-builder/tests/fixtures/builder/env-substitute/moon.yml	Updates fixtures to rely on auto-shell behavior.
crates/task-builder/tests/fixtures/builder/auto-shell/moon.yml	Adds fixtures to validate auto-shell detection + override.
crates/task-builder/tests/fixtures/builder/options-runinci/moon.yml	Adds fixtures for runInCI defaulting vs explicit config.
crates/config/src/workspace/hasher_config.rs	Adds default ignore patterns for missing inputs.
crates/app/src/commands/exec.rs	Temporarily disables CI shallow-checkout hard error.
crates/app/src/commands/docker/prune.rs	Adds debug logs and tweaks prune invocation handling.
crates/app-macros/src/lib.rs	Adds `MOON_INCLUDE_RELATIONS` env var support for `--include-relations`.
CHANGELOG.md	Documents the above behavior changes/fixes.

Comments suppressed due to low confidence (1)

crates/task-builder/src/tasks_builder.rs:493

Typo/grammar in this trace message: "as its required" should be "as it's required" or "as required".

            trace!(
                task_target = target.as_str(),
                "Task has defined a shell script, wrapping in a shell as its required",
            );

Copilot · 2026-02-25T18:15:19Z

packages/visualizer/src/helpers/render.ts

+			} else {
+				return `RunTask(${node.params.target})`;
+			}
+	}


getActionLabel has a code path that reaches the end of the function without returning a label. With noImplicitReturns enabled this will be a TS compile error, and it can also make row.label = getActionLabel(node) unsafe. Add an explicit default/fallback return (or an exhaustive never check) so the function always returns a string.

Suggested change

}

}

// Fallback label for unknown or future action types

return node.action;

Copilot · 2026-02-25T18:15:20Z

crates/config/src/workspace/hasher_config.rs

 use crate::shapes::GlobPath;
-use crate::{config_struct, config_unit_enum};
-use schematic::{Config, ConfigEnum};
+use crate::{PortablePath, config_struct, config_unit_enum};


PortablePath is imported but never used in this module. This will trigger an unused import warning (and can fail CI if warnings are denied). Remove the unused import or use it if it was intended for the new default function.

Suggested change

use crate::{PortablePath, config_struct, config_unit_enum};

use crate::{config_struct, config_unit_enum};

Copilot · 2026-02-25T18:15:20Z

crates/app/src/commands/exec.rs

        if result.shallow {
-            if self.ci_env {
-                return Err(AppError::CiNoShallowHistory.into());
-            } else {
-                self.affected = false;
-            }
+            // if self.ci_env {
+            //     return Err(AppError::CiNoShallowHistory.into());
+            // } else {
+            self.affected = false;


Large blocks of commented-out code (including the AppError import and the CI shallow-check branch) make it harder to understand the intended behavior and can easily go stale. Prefer a small explicit implementation (e.g., feature flag/env toggle + warning log) and remove the commented code.

crates/app/src/commands/docker/prune.rs

github-actions · 2026-02-25T18:16:31Z

Run report for 6527d9fe `(windows-latest)`

Total time: 1m 45s | Comparison time: 4m 36s | Estimated savings: 2m 50s (61.9% faster)

	Action	Time	Status
🟩	`SyncWorkspace`	410.4ms	Passed
🟩	`SyncProject(types)`	8.5ms	Passed
🟩	`SyncProject(visualizer)`	13.2ms	Passed
🟩	`SyncProject(runtime)`	15.2ms	Passed
🟩	`SyncProject(report)`	25.8ms	Passed
🟩	`SyncProject(website)`	42.3ms	Passed
🟩	`SetupProto(0.55.2)`	10.3s	Passed
🟩	`SetupToolchain(node:22.14.0)`	10s	Passed
🟩	`SetupToolchain(yarn:4.12.0)`	634.6ms	Passed
⬛️	`SetupToolchain(javascript)`	0.3ms	Skipped
🟩	`SetupEnvironment(javascript)`	5.7ms	Passed
🟩	`InstallDependencies(javascript)`	1m 3s	Passed
🟦	`RunTask(types:build)`	2.1s	Cached
🟦	`RunTask(visualizer:typecheck)`	384.7ms	Cached
🟦	`RunTask(visualizer:format)`	448.2ms	Cached
🟦	`RunTask(visualizer:lint)`	216.3ms	Cached
🟦	`RunTask(visualizer:test)`	366.6ms	Cached
🟦	`RunTask(runtime:build)`	843.9ms	Cached
🟦	`RunTask(report:build)`	919.5ms	Cached
🟦	`RunTask(visualizer:build)`	861.3ms	Cached
	And 1 more...

Expanded report

	Action	Time	Status	Info
🟦	`RunTask(website:build)`	17.6s	Cached

Environment

OS: Windows
Matrix:

os = windows-latest

Changed files

.github/workflows/publish-npm.yml
.github/workflows/rust.yml
.yarn/versions/8aff476a.yml
CHANGELOG.md
crates/app-macros/src/lib.rs
crates/app/src/commands/action_graph.rs
crates/app/src/commands/docker/prune.rs
crates/app/src/commands/exec.rs
crates/app/src/commands/graph/dto.rs
crates/app/src/commands/graph/mod.rs
crates/app/src/commands/graph/utils.rs
crates/app/src/commands/project_graph.rs
crates/app/src/commands/task_graph.rs
crates/cli/tests/__fixtures__/pipeline/shared/moon.yml
crates/cli/tests/exec_test.rs
crates/config/src/workspace/hasher_config.rs
crates/graph-utils/src/graph_formats.rs
crates/task-builder/src/tasks_builder.rs
crates/task-builder/tests/__fixtures__/builder/auto-shell/moon.yml
crates/task-builder/tests/__fixtures__/builder/env-substitute/moon.yml
crates/task-builder/tests/__fixtures__/builder/options-runinci/moon.yml
crates/task-builder/tests/__fixtures__/builder/syntax/moon.yml
crates/task-builder/tests/tasks_builder_test.rs
crates/task/src/task.rs
packages/report/package.json
packages/runtime/package.json
packages/types/package.json
packages/visualizer/package.json
packages/visualizer/src/helpers/render.ts
packages/visualizer/src/helpers/types.ts
packages/visualizer/tsconfig.json
scripts/release/publish.sh
scripts/release/release.sh
scripts/release/setupNpm.sh
website/docs/config/workspace.mdx
yarn.lock

github-actions · 2026-02-25T19:08:37Z

Run report for 6527d9fe `(ubuntu-latest)`

Total time: 1m 21s | Comparison time: 4m 34s | Estimated savings: 3m 12s (70.3% faster)

	Action	Time	Status
🟩	`SyncWorkspace`	321.2ms	Passed
🟩	`SyncProject(types)`	6.9ms	Passed
🟩	`SyncProject(visualizer)`	9.5ms	Passed
🟩	`SyncProject(runtime)`	15ms	Passed
🟩	`SyncProject(report)`	15.8ms	Passed
🟩	`SyncProject(website)`	9.4ms	Passed
🟩	`SetupProto(0.55.2)`	9.7s	Passed
🟩	`SetupToolchain(node:22.14.0)`	6.2s	Passed
🟩	`SetupToolchain(yarn:4.12.0)`	1.2s	Passed
⬛️	`SetupToolchain(javascript)`	0.2ms	Skipped
🟩	`SetupEnvironment(javascript)`	4.1ms	Passed
🟩	`InstallDependencies(javascript)`	40.8s	Passed
🟦	`RunTask(types:build)`	2.3s	Cached
🟦	`RunTask(visualizer:typecheck)`	218.6ms	Cached
🟦	`RunTask(visualizer:test)`	263.3ms	Cached
🟦	`RunTask(visualizer:lint)`	147.2ms	Cached
🟦	`RunTask(visualizer:format)`	274.4ms	Cached
🟦	`RunTask(visualizer:build)`	909.4ms	Cached
🟦	`RunTask(report:build)`	1.6s	Cached
🟦	`RunTask(runtime:build)`	1.4s	Cached
	And 1 more...

Expanded report

	Action	Time	Status	Info
🟦	`RunTask(website:build)`	19.4s	Cached

Environment

OS: Linux
Matrix:

os = ubuntu-latest

Changed files

.github/workflows/publish-npm.yml
.github/workflows/rust.yml
.yarn/versions/8aff476a.yml
CHANGELOG.md
crates/app-macros/src/lib.rs
crates/app/src/commands/action_graph.rs
crates/app/src/commands/docker/prune.rs
crates/app/src/commands/exec.rs
crates/app/src/commands/graph/dto.rs
crates/app/src/commands/graph/mod.rs
crates/app/src/commands/graph/utils.rs
crates/app/src/commands/project_graph.rs
crates/app/src/commands/task_graph.rs
crates/cli/tests/__fixtures__/pipeline/shared/moon.yml
crates/cli/tests/exec_test.rs
crates/config/src/workspace/hasher_config.rs
crates/graph-utils/src/graph_formats.rs
crates/task-builder/src/tasks_builder.rs
crates/task-builder/tests/__fixtures__/builder/auto-shell/moon.yml
crates/task-builder/tests/__fixtures__/builder/env-substitute/moon.yml
crates/task-builder/tests/__fixtures__/builder/options-runinci/moon.yml
crates/task-builder/tests/__fixtures__/builder/syntax/moon.yml
crates/task-builder/tests/tasks_builder_test.rs
crates/task/src/task.rs
packages/report/package.json
packages/runtime/package.json
packages/types/package.json
packages/visualizer/package.json
packages/visualizer/src/helpers/render.ts
packages/visualizer/src/helpers/types.ts
packages/visualizer/tsconfig.json
scripts/release/publish.sh
scripts/release/release.sh
scripts/release/setupNpm.sh
website/docs/config/workspace.mdx
yarn.lock

## Summary Kibana VM images are currently broken @ moon 2.0.1 due to us using a shallow clone for warming up the initial install/moon caches. Moon @ 2.0.4 has bugfixes and no errors on a shallow clone (moonrepo/moon#2384)

## Summary Kibana VM images are currently broken @ moon 2.0.1 due to us using a shallow clone for warming up the initial install/moon caches. Moon @ 2.0.4 has bugfixes and no errors on a shallow clone (moonrepo/moon#2384) (cherry picked from commit adab6fa) # Conflicts: # package.json # yarn.lock

milesj added 6 commits February 24, 2026 09:40

Disable shallow error.

9d0c608

Fix visualizer.

0313fcc

Add logs.

7222a20

Update defaults.

80ee449

Rework shell handling.

a45b040

Fix run in ci.

74cc417

Copilot AI review requested due to automatic review settings February 25, 2026 18:05

Copilot started reviewing on behalf of milesj February 25, 2026 18:06 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

Fix types.

1c7475a

milesj added 2 commits February 25, 2026 10:19

Bump package.

a459a5a

Add tests.

a25b124

milesj added 3 commits February 25, 2026 11:33

Fix test.

e994fe2

Add publish script.

c1ee168

Fix prune set.

6527d9f

milesj mentioned this pull request Feb 25, 2026

moon run silently filters out type: run tasks in CI after v2.0.0 #2382

Closed

milesj merged commit ac7f8da into master Feb 25, 2026
35 of 38 checks passed

milesj deleted the fixes-0224 branch February 25, 2026 21:57

delanni mentioned this pull request Mar 13, 2026

upgrade @moonrepo/cli to 2.0.4 elastic/kibana#257629

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Audit 02/24#2384

fix: Audit 02/24#2384
milesj merged 12 commits intomasterfrom
fixes-0224

milesj commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 25, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

-	}
+	}
+	// Fallback label for unknown or future action types
+	return node.action;

	use crate::{PortablePath, config_struct, config_unit_enum};
	use crate::{config_struct, config_unit_enum};

Uh oh!

Conversation

milesj commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Run report for 6527d9fe (windows-latest)

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Run report for 6527d9fe (ubuntu-latest)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Feb 25, 2026 •

edited

Loading

Run report for 6527d9fe `(windows-latest)`

github-actions bot commented Feb 25, 2026 •

edited

Loading

Run report for 6527d9fe `(ubuntu-latest)`